what if a language has multiple lsp available, how can I choose one explictly?

[gemini133]

for example,
the php has 3 lsps: intelephense, phpactor, phpantom
in the global config serena_config.yml

languages:
- php_phpantom

it doesn't work, it' still using intelephense.

I have to touch the core file

case self.PHP:
                from solidlsp.language_servers.intelephense import Intelephense

                return Intelephense

changed to

case self.PHP:
                from solidlsp.language_servers.phpantom import PHPantomServer

                return PHPantomServer

[opcode81]

The set of languages being is used is configured per project, not globally:
https://oraios.github.io/serena/02-usage/040_workflow.html#project-configuration

[opcode81]

@MischaPanch, I am not sure what you wanted

php: php_phpactor

to mean. Possibilities:

1. If the language is PHP, prefer php_phpactor (over everything else?)
2. Prefer php_phpactor over php

(2) would be an odd way to specify this; (1) would require a concept we don't have (programming language representation).
Since we represent only language servers, the natural thing to do, which maps directly to our selection algorithm, was to instead allow the user to alter the priorities associated with language servers:

ls_priorities:
  php_phpactor: 3

One can additionally specify php: 0 to fully replace Intelephense.

[MischaPanch]

I meant scenario 1, which we already have implicitly since we have a default LS for each language (the one currently used in the autogeneration), so we can reuse that concept. Priorities seem a bit weird to me since I suppose that a user would only be interested in selecting a single LS for a language

[opcode81]

No, we do not have the concept of a "programming language" or how to check whether a project is in a certain language.
We have only language servers and file extensions they understand.
The concept of "PHP" does not exist, and we currently do not know how to check for it - nor would it be preferable to the way in which we currently check applicability of language servers.
Given our representations, assigning priorities to language servers is the most natural thing to do.

[opcode81]

Docstring of the current implementation:

# mapping from language server keys to integer priority values (higher = more preferred), which are used
# when breaking ties between languages during language auto-detection during project creation.
# These priority values override Serena's default priorities:
#   * 0 = experimental/secondary language server (never auto-detected)
#   * 1 = supersets of other languages such that they are preferred only if they match more files
#   * 2 = default priority
# Example:
#   ls_priorities:
#     python: 0
#     python_basedpyright: 2
# This example would achieve that  `php_basedpyright` becomes the preferred language server for Python,
# giving it default priority 2, whereas the default Python language server becomes excluded with priority 0.
ls_priorities:

[opcode81]

@gemini133 the feature is now available on the main branch.

[gemini133]

Thanks guys!