Fix and improve immowelt/immonet provider#194
Merged
orangecoding merged 3 commits intoorangecoding:masterfrom Sep 27, 2025
Merged
Fix and improve immowelt/immonet provider#194orangecoding merged 3 commits intoorangecoding:masterfrom
orangecoding merged 3 commits intoorangecoding:masterfrom
Conversation
Contributor
gorgobacka
commented
Sep 25, 2025
gorgobacka
commented
- Parse description
- Use correct id for image
gorgobacka
force-pushed
the
improve-immowelt
branch
from
964be79 to
904493c
Compare
gorgobacka
changed the title
orangecoding
requested changes
Sep 26, 2025
Owner
orangecoding
left a comment
orangecoding
left a comment
There was a problem hiding this comment.
Thanks for this, however, there seem to be test failures. Can you run tests and make sure to fix this? Thanks :)
Contributor
Author
|
@orangecoding Sorry. I saw the word "timeout" in the CI and thoughts it is only a hiccup of the website and will be solved after a restart. But the problem was that the description is not always defined and can return Additionally, I refactored the code slightly to make an error more obvious instead of running in a "timeout". What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.