Skip to content

Add provider for Regionalimmobilien24#197

Merged
orangecoding merged 1 commit intoorangecoding:masterfrom
gorgobacka:add-regionalimmobilien24
Sep 27, 2025
Merged

Add provider for Regionalimmobilien24#197
orangecoding merged 1 commit intoorangecoding:masterfrom
gorgobacka:add-regionalimmobilien24

Conversation

@gorgobacka
Copy link
Copy Markdown
Contributor

Website: https://www.regionalimmobilien24.de/

This is my first own provider. Please let me know, if something can be improved.

@orangecoding
Copy link
Copy Markdown
Owner

@gorgobacka That's a perfect pr ;) As I have merged your previous pr, this one is now having a small conflict. Once resolved, I'll merge it as well. Thanks!

@gorgobacka gorgobacka force-pushed the add-regionalimmobilien24 branch from f92810b to 503c082 Compare September 27, 2025 09:12
@gorgobacka
Copy link
Copy Markdown
Contributor Author

@orangecoding Thanks a lot for checking. I rebased the branch onto master.

@orangecoding
Copy link
Copy Markdown
Owner

@gorgobacka Now the test is failing. Please run it locally.

  1) #regionalimmobilien24 testsuite()
       should test regionalimmobilien24 provider:
     TypeError: Cannot read properties of undefined (reading 'enabled')
      at Module.init (file:///home/runner/work/fredy/fredy/lib/provider/regionalimmobilien24.js:40:33)
      at Context.<anonymous> (file:///home/runner/work/fredy/fredy/test/provider/regionalimmobilien24.test.js:14:14)

@gorgobacka gorgobacka force-pushed the add-regionalimmobilien24 branch from 503c082 to 7131ec1 Compare September 27, 2025 11:43
@gorgobacka
Copy link
Copy Markdown
Contributor Author

Oh, no. An "o" got lost during the rebase. Sorry for this stupid mistake. Next time, I will be more careful.

It's fixed now.

@orangecoding orangecoding merged commit 4d37e89 into orangecoding:master Sep 27, 2025
2 checks passed
@orangecoding
Copy link
Copy Markdown
Owner

Thanks!

@gorgobacka gorgobacka deleted the add-regionalimmobilien24 branch September 27, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants