fix: notification adapter modal improvements #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
efekrskl
commented
Nov 13, 2025
efekrskl
commented
- Fixes notification adapter not responding to close events (e.g pressing X or ESC button)
- Adjusts notification adapter modal so it matches Provider modal style wise (button ordering, styles, modal size etc.)
- Changes Blacklist icon (right now Blacklist and Notification Adapters have same icons)
- Fixes minor typos
orangecoding
requested changes
Nov 14, 2025
| title="Adding a new Notification Adapter" | ||
| visible={visible} | ||
| style={{ width: '95%' }} | ||
| style={{ width: '50rem' }} |
Owner
There was a problem hiding this comment.
This will break using this on mobile...
Contributor
Author
There was a problem hiding this comment.
@orangecoding hey, yup, great points on both PRs. I'm a bit busy, but I'll get back to these.
Contributor
Author
There was a problem hiding this comment.
so I just got some time to get back to this:
you are right, this definitely breaks in mobile. however, this page already doesn't work on mobile, as the other modal already uses 50rem (and I copied this value from there). There are other minor issues like some buttons overflowing.
I pushed a commit checking for screen width so for larger screens we can have a smaller modal, and for smaller ones we could use 95%. This is just an idea though, lmk what you think :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.