feat!: implement the referrers route in the v2 package#32
feat!: implement the referrers route in the v2 package#32shizhMSFT merged 3 commits intooras-project:mainfrom wangxiaoxuan273:v2-pkg
Conversation
wangxiaoxuan273
changed the title
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
=======================================
Coverage 57.18% 57.18%
=======================================
Files 107 107
Lines 10982 10990 +8
=======================================
+ Hits 6280 6285 +5
- Misses 3999 4001 +2
- Partials 703 704 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
registry/api/v2/descriptors.go
Outdated
| Description: "Fetch the referrers of the artifact identified by `digest`.", | ||
| Requests: []RequestDescriptor{ | ||
| { | ||
| Name: "referrers", |
There was a problem hiding this comment.
nit:
| Name: "referrers", | |
| Name: "Referrers", |
registry/api/v2/descriptors.go
Outdated
| Format: `{ | ||
| "schemaVersion": 2, | ||
| "mediaType": "application/vnd.oci.image.index.v1+json", | ||
| "manifests": [ | ||
| <manifest>, | ||
| ... | ||
| ] | ||
| }`, |
registry/api/v2/descriptors.go
Outdated
| linkHeader, | ||
| }, | ||
| Body: BodyDescriptor{ | ||
| ContentType: "application/json", |
There was a problem hiding this comment.
Should it be application/vnd.oci.image.index.v1+json?
| { | ||
| Description: "The registry does not support referrers API.", | ||
| StatusCode: http.StatusNotFound, | ||
| }, |
There was a problem hiding this comment.
It is also possible that the repository does not exists.
/cc @Wwwsylvia @m5i-work
There was a problem hiding this comment.
We should return 404 and error code NAME_UNKNOWN when the repository does not exist.
References:
There was a problem hiding this comment.
Added the variable repositoryNotFoundResponseDescriptor defined in descriptors.go to address this scenario. It satisfies your specifications.
Now the Failures responses look like this, note the added line:
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
4 participants
Implement the
referrersroute in theregistry/api/v2package. Path with filtering onArtifactTypeis also implemented. Unit tests are included. The next pr will implementreferrersHandlerbut probably will not implement filtering yet.Part 5 of #21
Signed-off-by: wangxiaoxuan273 wangxiaoxuan119@gmail.com