Skip to content

fix: should return empty manifest list when no referrers are found#53

Merged
shizhMSFT merged 2 commits intooras-project:mainfrom
wangxiaoxuan273:null-fix
Jan 5, 2023
Merged

fix: should return empty manifest list when no referrers are found#53
shizhMSFT merged 2 commits intooras-project:mainfrom
wangxiaoxuan273:null-fix

Conversation

@wangxiaoxuan273
Copy link
Copy Markdown

@wangxiaoxuan273 wangxiaoxuan273 commented Jan 4, 2023

Resolves #51
Signed-off-by: wangxiaoxuan273 wangxiaoxuan119@gmail.com

Current output:
First test case: 0 referrers are found.
Second test case: call with a manifest digest that is nonexistent in the repository, returns an empty manifest list.
image

Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Copy link
Copy Markdown

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 2ba5caa into oras-project:main Jan 5, 2023
@wangxiaoxuan273 wangxiaoxuan273 deleted the null-fix branch January 5, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: referrers should return an empty manifest list, but it now returns null

2 participants