Add tests for error handling and retry scenarios in RegistryWireMockTest#165
Merged
jonesbusy merged 1 commit intooras-project:mainfrom Feb 28, 2025
Merged
Conversation
Contributor
Author
|
I attempted to run tests in parallel, but they remain flaky. I also used dynamic ports and even tried reinitializing WireMock instances. No luck finding why they remain flaky. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
============================================
+ Coverage 82.82% 83.16% +0.34%
- Complexity 299 308 +9
============================================
Files 26 27 +1
Lines 1077 1093 +16
Branches 104 105 +1
============================================
+ Hits 892 909 +17
+ Misses 130 129 -1
Partials 55 55 ☔ View full report in Codecov by Sentry. |
jonesbusy
reviewed
Feb 27, 2025
jonesbusy
requested changes
Feb 27, 2025
jonesbusy
approved these changes
Feb 28, 2025
Collaborator
|
Can you ensure all commits are signed? Ideally the PR need to be rebased and only one commmits must be present (for such small change). When done I will merge Thanks |
5d37044 to
f475ba4
Compare
Signed-off-by: vaidikcode <vaidikbhardwaj00@gmail.com>
f475ba4 to
9211ba6
Compare
Contributor
Author
Done |
jonesbusy
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vaidikcode vaidikbhardwaj00@gmail.com
Description
Issue #23
This PR improves test coverage for the Registry client by adding three new test methods:
shouldHandle500Error: Tests the client's ability to properly handle HTTP 500 errors from the registry and convert them into OrasExceptions with the correct status code.shouldHandleTimeout: Tests the client's handling of HTTP 408 (Request Timeout) responses, ensuring that timeout conditions are properly propagated as OrasExceptions.shouldRetryBlobUpload: Implements scenario-based testing using WireMock to verify that the client can successfully retry blob uploads after an initial server error. This test demonstrates the retry capability of the Registry client when pushing content.Testing done
Tests run successfully in isolation and in sequence
Some existing test failures in other classes are unrelated to these changes
Submitter checklist
mvn license:update-file-header,mvn spotless:apply,pre-commit run -a,mvn clean installbefore opening the PR