Replace docker.io by registry-1.docker.io when doing api calls#179
Merged
jonesbusy merged 1 commit intooras-project:mainfrom Mar 2, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
============================================
+ Coverage 83.67% 84.07% +0.40%
- Complexity 327 332 +5
============================================
Files 29 29
Lines 1158 1162 +4
Branches 110 112 +2
============================================
+ Hits 969 977 +8
+ Misses 132 128 -4
Partials 57 57 ☔ View full report in Codecov by Sentry. |
jonesbusy
force-pushed
the
feature/replace-docker-io
branch
2 times, most recently
from
3d71867 to
7f80dfa
Compare
Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
jonesbusy
force-pushed
the
feature/replace-docker-io
branch
from
7f80dfa to
0b38825
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Should fix #177
Similar to https://github.com/oras-project/oras-py/blob/1790ad7df3c83884f24aabd2ab4b2d97e4c2f3b0/oras/defaults.py#L10-L15 and https://github.com/oras-project/oras-go/blob/d92df9df65805259b6f3b8114d9dc939d71f5264/registry/reference_test.go#L235-L249
Testing done
CI only
Submitter checklist
mvn license:update-file-header,mvn spotless:apply,pre-commit run -a,mvn clean installbefore opening the PR