Skip to content

Fix push into OCI with tag#210

Merged
jonesbusy merged 1 commit intooras-project:mainfrom
jonesbusy:feature/fix-pull-oci
Mar 10, 2025
Merged

Fix push into OCI with tag#210
jonesbusy merged 1 commit intooras-project:mainfrom
jonesbusy:feature/fix-pull-oci

Conversation

@jonesbusy
Copy link
Copy Markdown
Collaborator

Description

Fix push into OCI with tag

Found during interactive tests.

Testing done

Added a new automated test

Submitter checklist

  • I have read and understood the CONTRIBUTING guide
  • I have run mvn license:update-file-header, mvn spotless:apply, pre-commit run -a, mvn clean install before opening the PR

@jonesbusy jonesbusy added the bug Something isn't working label Mar 10, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 76.74419% with 10 lines in your changes missing coverage. Please review.

Project coverage is 84.99%. Comparing base (4943281) to head (08caeae).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/main/java/land/oras/OCILayout.java 73.91% 2 Missing and 4 partials ⚠️
src/main/java/land/oras/Registry.java 71.42% 2 Missing ⚠️
src/main/java/land/oras/utils/JsonUtils.java 33.33% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (76.74%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #210      +/-   ##
============================================
- Coverage     85.14%   84.99%   -0.15%     
- Complexity      429      439      +10     
============================================
  Files            33       33              
  Lines          1447     1473      +26     
  Branches        164      174      +10     
============================================
+ Hits           1232     1252      +20     
- Misses          143      146       +3     
- Partials         72       75       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonesbusy jonesbusy force-pushed the feature/fix-pull-oci branch 5 times, most recently from f344299 to 11738ac Compare March 10, 2025 09:05
Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
@jonesbusy jonesbusy force-pushed the feature/fix-pull-oci branch from 11738ac to 08caeae Compare March 10, 2025 09:11
@jonesbusy jonesbusy marked this pull request as ready for review March 10, 2025 09:13
@jonesbusy jonesbusy merged commit 7fb04b7 into oras-project:main Mar 10, 2025
@jonesbusy jonesbusy deleted the feature/fix-pull-oci branch March 10, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant