Skip to content

Manifest annotations where not copied to index#218

Merged
jonesbusy merged 1 commit intooras-project:mainfrom
jonesbusy:feature/cleanup-from-json
Mar 15, 2025
Merged

Manifest annotations where not copied to index#218
jonesbusy merged 1 commit intooras-project:mainfrom
jonesbusy:feature/cleanup-from-json

Conversation

@jonesbusy
Copy link
Copy Markdown
Collaborator

@jonesbusy jonesbusy commented Mar 15, 2025

Small issue I discovered comparing the java and go implementation

Test were indeed wrong

Manifest annotations where not copied to index

And added some cleanup

Description

Testing done

Submitter checklist

  • I have read and understood the CONTRIBUTING guide
  • I have run mvn license:update-file-header, mvn spotless:apply, pre-commit run -a, mvn clean install before opening the PR

Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
@jonesbusy jonesbusy added the bug Something isn't working label Mar 15, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 15, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.41%. Comparing base (38220a8) to head (8bdd0a0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/main/java/land/oras/Index.java 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #218      +/-   ##
============================================
- Coverage     85.43%   85.41%   -0.02%     
- Complexity      450      453       +3     
============================================
  Files            33       33              
  Lines          1497     1502       +5     
  Branches        173      174       +1     
============================================
+ Hits           1279     1283       +4     
  Misses          144      144              
- Partials         74       75       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonesbusy jonesbusy marked this pull request as ready for review March 15, 2025 09:38
@jonesbusy jonesbusy merged commit 5182d5e into oras-project:main Mar 15, 2025
@jonesbusy jonesbusy deleted the feature/cleanup-from-json branch March 15, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant