Do not fail if XDG_RUNTIME_DIR is not set#255
Merged
jonesbusy merged 1 commit intooras-project:mainfrom Apr 12, 2025
Merged
Conversation
Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
============================================
+ Coverage 85.31% 85.33% +0.01%
- Complexity 479 480 +1
============================================
Files 34 34
Lines 1594 1596 +2
Branches 178 179 +1
============================================
+ Hits 1360 1362 +2
Misses 156 156
Partials 78 78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not fail if XDG_RUNTIME_DIR is not set
Fix #250
Also added a bit more tests that should help supporting better podman config to select correct credentials oras-project/oras-go#918 and containers-registries.conf based Container Registry alias etc....
Testing done
mvn clean install and add/update tests
Submitter checklist
mvn license:update-file-header,mvn spotless:apply,pre-commit run -a,mvn clean installbefore opening the PR