Skip to content

Do not fail if XDG_RUNTIME_DIR is not set#255

Merged
jonesbusy merged 1 commit intooras-project:mainfrom
jonesbusy:feature/do-not-fail-XDG_RUNTIME_DIR-not-set
Apr 12, 2025
Merged

Do not fail if XDG_RUNTIME_DIR is not set#255
jonesbusy merged 1 commit intooras-project:mainfrom
jonesbusy:feature/do-not-fail-XDG_RUNTIME_DIR-not-set

Conversation

@jonesbusy
Copy link
Copy Markdown
Collaborator

Description

Do not fail if XDG_RUNTIME_DIR is not set

Fix #250

Also added a bit more tests that should help supporting better podman config to select correct credentials oras-project/oras-go#918 and containers-registries.conf based Container Registry alias etc....

Testing done

mvn clean install and add/update tests

Submitter checklist

  • I have read and understood the CONTRIBUTING guide
  • I have run mvn license:update-file-header, mvn spotless:apply, pre-commit run -a, mvn clean install before opening the PR

Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
@jonesbusy jonesbusy added the bug Something isn't working label Apr 12, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.33%. Comparing base (c847a25) to head (71acd5c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #255      +/-   ##
============================================
+ Coverage     85.31%   85.33%   +0.01%     
- Complexity      479      480       +1     
============================================
  Files            34       34              
  Lines          1594     1596       +2     
  Branches        178      179       +1     
============================================
+ Hits           1360     1362       +2     
  Misses          156      156              
  Partials         78       78              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonesbusy jonesbusy marked this pull request as ready for review April 12, 2025 10:03
@jonesbusy jonesbusy merged commit d94f4f4 into oras-project:main Apr 12, 2025
4 checks passed
@jonesbusy jonesbusy deleted the feature/do-not-fail-XDG_RUNTIME_DIR-not-set branch April 12, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

default AuthStore gives NPE where XDG_RUNTIME_DIR is not present

1 participant