Skip to content

Add insecure and plain-http flag when pull and push#122

Merged
jdolitsky merged 1 commit intooras-project:masterfrom
pytimer:pull-push-insecure
Oct 17, 2019
Merged

Add insecure and plain-http flag when pull and push#122
jdolitsky merged 1 commit intooras-project:masterfrom
pytimer:pull-push-insecure

Conversation

@pytimer
Copy link
Contributor

@pytimer pytimer commented Aug 30, 2019

This is the first commit about pull/push to an insecure registry.

This PR implement pull or push to an insecure registry using the CNAME, but using the ip address is wrong. So this PR setting WIP.

If someone know why, please tell me, thanks.

TODO:

  • pull/push to an insecure registry using the ip address, such as 192.168.100.20:8443.
  • add --plain-http to pull or push a HTTP registry.

Related issue:

@jdolitsky
Copy link
Contributor

@pytimer this looks good so far. If we could add some section to your part in the readme like "please use --insecure on push and pull"

@jdolitsky
Copy link
Contributor

/test

@pytimer
Copy link
Contributor Author

pytimer commented Aug 30, 2019

@jdolitsky This insecure flag is invalid for using ip address to access an insecure registry, do you know why?

I have no idea about it, so I think it maybe can not merge if this question not solved.

@pytimer pytimer force-pushed the pull-push-insecure branch 2 times, most recently from 9583458 to 8cbfc1e Compare September 2, 2019 07:55
@pytimer pytimer changed the title [WIP] Add insecure flag when pull and push Add insecure and plain-http flag when pull and push Sep 2, 2019
@pytimer
Copy link
Contributor Author

pytimer commented Sep 2, 2019

@jdolitsky I finish this feature, hope you can review it.

I also update the README.md about this feature usage, my english not good, so if not described clearly, please point out.

Copy link
Contributor

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pytimer thanks for looking into this. I left a few comments.

It's also unclear why we now need --plain-http for localhost:5000 (or do we?) I think the new flag is only needed for IP address as host

@pytimer
Copy link
Contributor Author

pytimer commented Sep 3, 2019

@jdolitsky Sorry, my example not descirbed clearly, i update the README.md, you can see again.

The --plain-http used when using with the plain HTTP registry, --insecure used when using with the insecure HTTPS registry.

@jdolitsky
Copy link
Contributor

/test

@zygon4
Copy link

zygon4 commented Oct 14, 2019

@pytimer is the entire commit for this PR held back due to this conflict? Is anyone looking at finishing the merge?

Thanks!

@pytimer pytimer force-pushed the pull-push-insecure branch from 2666ce5 to 9441b80 Compare October 15, 2019 12:03
@pytimer
Copy link
Contributor Author

pytimer commented Oct 15, 2019

@zygon4 I waiting review completed.

@jdolitsky @zygon4 I solve the conflict files and move documents to implementors.md, please review them. Thanks.

@zygon4
Copy link

zygon4 commented Oct 16, 2019

@zygon4 I waiting review completed.

@jdolitsky @zygon4 I solve the conflict files and move documents to implementors.md, please review them. Thanks.

Thanks so much! I don't think I'm qualified to review, however. @jdolitsky ?

Thanks again!

@jdolitsky jdolitsky merged commit bbe4258 into oras-project:master Oct 17, 2019
@jdolitsky
Copy link
Contributor

thanks again @pytimer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants