Add insecure and plain-http flag when pull and push#122
Add insecure and plain-http flag when pull and push#122jdolitsky merged 1 commit intooras-project:masterfrom
Conversation
|
@pytimer this looks good so far. If we could add some section to your part in the readme like "please use --insecure on push and pull" |
|
/test |
|
@jdolitsky This insecure flag is invalid for using ip address to access an insecure registry, do you know why? I have no idea about it, so I think it maybe can not merge if this question not solved. |
9583458 to
8cbfc1e
Compare
|
@jdolitsky I finish this feature, hope you can review it. I also update the README.md about this feature usage, my english not good, so if not described clearly, please point out. |
8cbfc1e to
2666ce5
Compare
|
@jdolitsky Sorry, my example not descirbed clearly, i update the README.md, you can see again. The |
|
/test |
|
@pytimer is the entire commit for this PR held back due to this conflict? Is anyone looking at finishing the merge? Thanks! |
2666ce5 to
9441b80
Compare
|
@zygon4 I waiting review completed. @jdolitsky @zygon4 I solve the conflict files and move documents to implementors.md, please review them. Thanks. |
Thanks so much! I don't think I'm qualified to review, however. @jdolitsky ? Thanks again! |
|
thanks again @pytimer ! |
This is the first commit about pull/push to an insecure registry.
This PR implement pull or push to an insecure registry using the CNAME, but using the ip address is wrong. So this PR setting WIP.
If someone know why, please tell me, thanks.
TODO:
192.168.100.20:8443.--plain-httpto pull or push a HTTP registry.Related issue: