move reporting of status to library#179
Merged
jdolitsky merged 2 commits intooras-project:masterfrom Oct 1, 2020
Merged
Conversation
Contributor
|
/test |
Signed-off-by: Avi Deitcher <avi@deitcher.net>
deitch
force-pushed
the
report-as-option
branch
from
db0e32a to
ea58978
Compare
Contributor
Author
|
This is still open. Can I get a review on it @jdolitsky @SteveLasker ? Let's get it in? |
Contributor
|
We have CI broken right now.. opened #183 to address, then we should be good w/ this |
jdolitsky
approved these changes
Oct 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #140, specifically this comment by @SteveLasker
One interesting point. I took it "as is" and gave it the ability to accept an
io.Writer. Personally, I would prefer something that accepts the logging interface, so that I can pass it as:and then rather than calling
fmt.Fprintf(writer), we can just calllog.Debug()or similar.The problem is that log isn't an interface, it is an actual implementation that people pick. This may be good enough for now, and then we can iterate upon it.