Add flag to make manifest and tar reproducible#2039
Open
afbjorklund wants to merge 1 commit intooras-project:mainfrom
Open
Add flag to make manifest and tar reproducible#2039afbjorklund wants to merge 1 commit intooras-project:mainfrom
afbjorklund wants to merge 1 commit intooras-project:mainfrom
Conversation
afbjorklund
requested review from
TerryHowe,
Wwwsylvia,
sabre1041,
sajayantony and
shizhMSFT
as code owners
This will set the timestamps to the zero time.Time timestamp, to avoid it being set to the current/modification timestamp. For the manifest this translates to 0001-01-01, but for the tarball it translates to 1970-01-01 (since it uses seconds). Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will set the timestamps to the zero time.Time timestamp, to avoid it being set to the current/modification timestamp.
For the manifest this translates to 0001-01-01, but for the tarball it translates to 1970-01-01 (since it uses seconds).
What this PR does / why we need it:
Adds
--reproducibleflag, to push and attach.This will make their resulting digests deterministic.
Which issue(s) this PR fixes:
Fixes #1464
Please check the following list: