fix: use VerifyReader to verify read content after oras.Fetch#589
Merged
shizhMSFT merged 2 commits intooras-project:mainfrom Sep 21, 2022
wangxiaoxuan273:verify-reader
Merged
fix: use VerifyReader to verify read content after oras.Fetch#589shizhMSFT merged 2 commits intooras-project:mainfrom wangxiaoxuan273:verify-reader
shizhMSFT merged 2 commits intooras-project:mainfrom
wangxiaoxuan273:verify-reader
Conversation
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #589 +/- ##
=======================================
Coverage 72.54% 72.54%
=======================================
Files 14 14
Lines 510 510
=======================================
Hits 370 370
Misses 112 112
Partials 28 28 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shizhMSFT
requested changes
Sep 21, 2022
cmd/oras/blob/fetch.go
Outdated
Comment on lines
120
to
123
| buf := bytes.NewBuffer(nil) | ||
| if _, err := io.Copy(buf, vr); err != nil { | ||
| return err | ||
| } |
Contributor
There was a problem hiding this comment.
Blobs are usually large and cannot be dumped into memory.
Contributor
Author
There was a problem hiding this comment.
Fixed according to our offline discussion.
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
TerryHowe
pushed a commit
to TerryHowe/oras
that referenced
this pull request
Feb 2, 2023
…roject#589) Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #547
Signed-off-by: wangxiaoxuan273 wangxiaoxuan119@gmail.com