fix(ios): TestFlight marketing-version + CFBundleVersion (lost from #207)#208
Merged
Conversation
…ersion) The App Store Connect record for Lisa Pocket is at version 1.0 (PREPARE_FOR_SUBMISSION), with builds under the 1.0 train. project.yml still carried a stale "0.1.0", so testflight.sh archives declared CFBundleShortVersionString 0.1.0 — LOWER than 1.0. App Store Connect silently rejects a too-low marketing version at ingestion: the upload reports "EXPORT SUCCEEDED" but no build ever appears in TestFlight (no 0.1.0 train is even created). Together with the build-number fix in this branch, this is the second half of "why don't my uploads show up." Bump to 1.0 so archives attach to the existing train by default. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ide was a no-op)
xcodegen writes a LITERAL CFBundleVersion ("1") into Sources/Info.plist and
Widgets/Info.plist, so `xcodebuild archive … CURRENT_PROJECT_VERSION=$BUILD_NUMBER`
never changed the shipped build number — every archive was build "1". App Store
Connect kept rejecting them as "Redundant Binary Upload" (and the earlier ones
under the wrong 0.1.0 train vanished outright).
After `xcodegen generate`, plutil-replace CFBundleVersion in both the app and the
widget extension (they must match, or embedded-binary validation fails) with
$BUILD_NUMBER. Verified locally: post-generate both read "1"; post-patch both read
the timestamp and are equal.
Third of three TestFlight-upload fixes in this branch (build# < 2^32, marketing
version >= app version, and now the build# actually reaching the binary).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #207 squash-merged with only its first commit (build#
date +%s); these two fixes were pushed to the branch afterward and never reached main. Both are required — without them./testflight.shfrom main still silently fails (verified: build1782924012— the one now VALID in TestFlight — was built with all three).MARKETING_VERSION0.1.0 → 1.0 — must be ≥ the app's ASC version (1.0) or the upload is silently rejected at ingestion.CFBundleVersioninto the generated Info.plists (app + widget) afterxcodegen generate— xcodegen bakes a literal "1", so theCURRENT_PROJECT_VERSIONoverride was a no-op → "Redundant Binary Upload".🤖 Generated with Claude Code