feat(api): add webhook validation and parsing#111
Merged
Conversation
added 2 commits
November 11, 2024 19:54
| } | ||
| } | ||
|
|
||
| @OptIn(ExperimentalStdlibApi::class) |
Contributor
There was a problem hiding this comment.
What is the experimental thing we're using?
Contributor
Author
There was a problem hiding this comment.
My IDE was saying this was needed for toHexString... but it works if I remove it!
Contributor
Author
There was a problem hiding this comment.
Unfortunately I had to add this back @TomerAberbach. I get compile time warnings without it.
stainless-app
Bot
force-pushed
the
next
branch
from
f3be701 to
d56a0d4
Compare
TomerAberbach
suggested changes
Nov 18, 2024
| @@ -0,0 +1,13 @@ | |||
| // File generated from our OpenAPI spec by Stainless. | |||
Contributor
There was a problem hiding this comment.
Do we actually want this comment? The file wasn't generated I guess. Same for the other added files
Contributor
Author
There was a problem hiding this comment.
I think it's a good warning since we do plan to generate this code in the future?
| } | ||
|
|
||
| @Test | ||
| fun verifySignature() { |
Contributor
There was a problem hiding this comment.
It's better practice to separate tests into separate cases, even for the same method, instead of testing all the cases in a single test. Can we split this up?
See these for some guidance:
Co-authored-by: Tomer Aberbach <tomer@aberba.ch>
TomerAberbach
approved these changes
Nov 18, 2024
Merged
stainless-app Bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
* add webhook helpers * add webhook helpers * pr comments * Apply suggestions from code review Co-authored-by: Tomer Aberbach <tomer@aberba.ch> * refactor tests --------- Co-authored-by: David Meadows <dtmeadows@stainlessapi.com> Co-authored-by: Tomer Aberbach <tomer@aberba.ch>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.