Packet Loss MQTT definition - unit_of_measurement missing

[adamind]

Hi team
Thanks for making this available
I've noticed that the "Packet Loss" MQTT Sensor is not getting updated in Home Assistant
I can see the current Orb Sensor Packet Loss (sensor.orb_sensor_packet_loss) defined in Home Assistant as follows:

MQTT discovery data:
Topic: homeassistant/sensor/orb_packet_loss/config
Payload
state_topic: orb_homeassistant/status
unit_of_measurement: ''
value_template: >-
  {{
  value_json.orb_score.components.reliability_score.components.internet_loss_status.value
  | round(0) }}
unique_id: packet_loss
device:
  identifiers:
    - orb
  manufacturer: Orb Forge
  model: Orb Agent
  name: Orb Sensor
name: Packet Loss

Note the value_template is split over two lines, which I believe is an issue and may be causing this issue. unit_of_measurement is also missing

I see mqtt.sh is generating the above, and the Packet Loss line in the mapping section is missing a % at the end

[mignaulo]

hi @adamind! thanks for the PR, I merged it - makes sense to me 👍 Let me know if this fixes the issue for you?

[adamind]

Thanks @mignaulo, this is definitely a step in the right direction - I can now see Packet Loss changing in the Home Assistant sensor for it, however it seems to only go from 0 to 1% when the internet is down
Looking at the MQTT data, this is makes sense given it is using value_json.orb_score.components.reliability_score.components.internet_loss_status.value and rounding down
Seems that when the connection is normal and there is no loss, the MQTT data is like this:
internet_loss_status:
score: 1
display: 100
value: 0
When I manually drop my internet connection the MQTT data is like this:
internet_loss_status:
score: 0.0008614788952283168
display: 0
value: 1
Seems that when the internet is reconnected but there is some loss the MQTT data is like this:
internet_loss_status:
score: 0.018255678619482216
display: 5
value: 0.3218168155631627
I can't seem to find any documentation on what the value, score and display actually mean for internet_loss_status - can you please point me in the right direction?
I was assuming the value would be the actual percentage of packet loss but I don't think that is correct - perhaps 100-display needs to be used?

[mignaulo]

Hi @adamind - you're totally correct, internet_loss_status is not what you might expect here. To give some context, we score your reliability based on how often your connection has high packetloss. The internet_loss_status is exactly that - the proportion of time we saw high packetloss on your connection. so if you saw 10% or 20% packetloss for 2 minutes out of 5, you'd have 40% as your internet_loss_status for that period.
We'll discuss this internally to see if we can expose the raw packetloss, but for now I'll just update the addon to better name the field in question. https://github.com/orbforge/addon-orb/pull/9/files

[adamind]

Excellent, thanks a lot @mignaulo

[aind-splunk]

Changes from #9 with the new "High Packet Loss Proportion" look good @mignaulo, thanks!