Skip to content

rename graft_sqlite_extension to graft_ext#253

Merged
carlsverre merged 3 commits into
mainfrom
feat/rename-ext
Dec 3, 2025
Merged

rename graft_sqlite_extension to graft_ext#253
carlsverre merged 3 commits into
mainfrom
feat/rename-ext

Conversation

@carlsverre
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings December 3, 2025 19:07
@carlsverre carlsverre enabled auto-merge December 3, 2025 19:07
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Dec 3, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
graft-dev 23a956c Commit Preview URL

Branch Preview URL
Dec 03 2025, 07:17 PM

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR comprehensively renames the SQLite extension package from graft-sqlite-extension to graft-ext. The rename affects the Rust crate name, generated library file names (from libgraft_sqlite_extension to libgraft_ext), and all references throughout build scripts, documentation, and CI/CD workflows.

Key changes:

  • Renamed Rust crate from graft-sqlite-extension to graft-ext in Cargo.toml and Cargo.lock
  • Updated all library file references: libgraft_sqlite_extension.{so,dylib} and graft_sqlite_extension.dlllibgraft_ext.{so,dylib} and graft_ext.dll
  • Updated release artifact names to include -ext- suffix (e.g., libgraft-ext-linux-x86_64.tar.gz)
  • Updated documentation to reflect the new module name libgraft_ext in Swift/iOS examples
  • Modified CI/CD workflows to build and package the renamed extension

Reviewed changes

Copilot reviewed 18 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tasks/sqlite/test Updated cargo build command and library paths for all platforms
tasks/sqlite/shell Updated cargo build command and library paths for all platforms
tasks/package-archives Updated library names and archive names to use graft_ext and libgraft-ext prefixes
sqlpkg.json Updated download URLs to reference new -ext- artifact names
justfile Updated cargo build commands to use graft-ext package name
docs/src/content/docs/docs/sqlite/usage/ios.mdx Updated Swift import and function call to use libgraft_ext module
docs/src/content/docs/docs/sqlite/usage/direct.mdx Updated download links and documentation references to use new naming
docs/src/content/docs/docs/sqlite/index.md Removed specific libgraft naming references in favor of generic "extension" terminology
docs/src/content/docs/docs/sqlite/config.md Simplified documentation to refer generically to "the extension" rather than libgraft
docs/src/content/docs/docs/sqlite/compatibility.md Updated to refer to "the extension" instead of libgraft extension
docs/src/content/docs/docs/internals/index.md Updated architecture diagram to show libgraft_ext instead of libgraft
crates/graft-sqlite-extension/include/module.modulemap Removed old modulemap file
crates/graft-ext/src/lib.rs New implementation file for renamed crate
crates/graft-ext/include/module.modulemap New modulemap defining libgraft_ext module
crates/graft-ext/include/libgraft_ext.h New header file for the renamed extension
crates/graft-ext/Cargo.toml Updated package name to graft-ext
README.md Updated documentation links and removed specific libgraft naming
Cargo.lock Renamed package entry from graft-sqlite-extension to graft-ext
AGENTS.md Updated build command reference (with issue noted in review)
.github/workflows/release.yml Added libgraft.swift repository to token permissions
.github/workflows/release-prep.yml Updated all artifact paths, package names, and build commands to use graft_ext naming

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread AGENTS.md
| macOS | x86_64 | [libgraft-ext-macos-x86_64.tar.gz] |
| macOS | aarch64 | [libgraft-ext-macos-aarch64.tar.gz] |

After downloading the file for your system's platform and architecture, decompress the file to access the extension, which is named `libgraft.[dll,dylib,so]`.
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extension file names should be updated to reflect the rename. The actual library files are now named libgraft_ext.[dll,dylib,so], not libgraft.[dll,dylib,so]. This should read:

After downloading the file for your system's platform and architecture, decompress the file to access the extension, which is named `libgraft_ext.[dll,dylib,so]`.

This is consistent with the library paths shown in the build scripts (e.g., libgraft_ext.so, graft_ext.dll, libgraft_ext.dylib).

Suggested change
After downloading the file for your system's platform and architecture, decompress the file to access the extension, which is named `libgraft.[dll,dylib,so]`.
After downloading the file for your system's platform and architecture, decompress the file to access the extension, which is named `libgraft_ext.[dll,dylib,so]`.

Copilot uses AI. Check for mistakes.
@carlsverre carlsverre disabled auto-merge December 3, 2025 19:17
@carlsverre carlsverre merged commit c95545b into main Dec 3, 2025
4 of 6 checks passed
@carlsverre carlsverre deleted the feat/rename-ext branch December 3, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants