Skip to content
This repository was archived by the owner on Jan 10, 2026. It is now read-only.

Remove jquery from pipeline editor and add minor UX improvements#748

Merged
iannbing merged 80 commits intodevfrom
improv/remove-jquery-from-pipeline-editor
Mar 9, 2022
Merged

Remove jquery from pipeline editor and add minor UX improvements#748
iannbing merged 80 commits intodevfrom
improv/remove-jquery-from-pipeline-editor

Conversation

@iannbing
Copy link
Copy Markdown
Contributor

@iannbing iannbing commented Mar 1, 2022

Description

This PR aims at removing jQuery and RefManager from PipelineView component in order to make the implementation closer to the React way.

The refactoring also comes with some improvements on the drag-n-drop behavior, including:

  • when select/drag a step, the step and its connections (lines) will be moved to top, making them visually recognizable
  • when a connection line is selected, the start/end dots will also be highlighted.
  • several minor bugs were fixed, e.g. connection lines sometimes are visually gone.

Checklist

  • The PR branch is set up to merge into dev instead of master.

@iannbing
Improve typing
8823461
@iannbing
WIP
16ee798
@iannbing
WIP
b80f3c9
@iannbing
WIP
ff0f133
@iannbing
WIP
5a0f14b
@iannbing
WIP
2f96c15
@iannbing
WIP
9a68905
@iannbing
WIP
d7cbfe7
@iannbing
Only render when dragging
a754974
@iannbing
use original state in immutable reducer
9f88d78
@iannbing
fix connection issue, add virtural bg to step
827bf12
@iannbing
FIx willCreateCycle
166e8af
@iannbing
fix useEventVars reducer issue
0285716 
enable ctrl/cmd de/selection
move item to top (z-index) when selected
fix connection movement wrong calculation
@iannbing
fix scaling issue
0a62774
@iannbing
cursorControlledStep
b44a9bf
@iannbing
add onMouseDown to prevent bubbling
6aa2266
@iannbing
save and persists new connection
e780a9c
@iannbing
consolidate create connection behavior
5840db6
@iannbing
fix auto-layout
2136232
@iannbing
finalize auto layout
4a7b713
@iannbing
fix mouse up on step when selector is active
ba20a1b
@iannbing
fix selector first-click scaling issue
1e038a9
@iannbing
useZIndexMax
f30b0ce
@iannbing
ensure connection dots are on top when connection is selected
22ac1cd
@iannbing
Restructure files and folders
1d7fdef
@iannbing
double click on step
d6e9ca7
@iannbing
Clean up Step Details
6048406
@iannbing
pipelineJson.services can be null
2a86b87
@iannbing
add centerView with "h"
0851b5f
@iannbing
mouse cursor styling for panning
d74820f
@iannbing iannbing force-pushed the improv/remove-jquery-from-pipeline-editor branch from 9a3d757 to 22c50e2 Compare March 8, 2022 17:52
@iannbing iannbing force-pushed the improv/remove-jquery-from-pipeline-editor branch from 22c50e2 to e8c3bb3 Compare March 8, 2022 18:46
@iannbing iannbing merged commit ce5f85a into dev Mar 9, 2022
@iannbing iannbing deleted the improv/remove-jquery-from-pipeline-editor branch March 9, 2022 08:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ricklamers ricklamers ricklamers left review comments

@yannickperrenet yannickperrenet yannickperrenet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

improvement An improvement or enhancement to an existing feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iannbing @yannickperrenet @ricklamers