delete unused code and fix ocLineItems unit tests#123
Merged
amrarick26 merged 2 commits intoordercloud-api:developmentfrom Jun 6, 2017
Merged
delete unused code and fix ocLineItems unit tests#123amrarick26 merged 2 commits intoordercloud-api:developmentfrom
amrarick26 merged 2 commits intoordercloud-api:developmentfrom
Conversation
Contributor
crhistianramirez
commented
Jun 5, 2017
crhistianramirez
commented
- remove customShipping method from ocLineItems. This is used on line item level shipping which hasn't been created and will likely differ from its current implementation.
- update ocLineItems unit tests so that they are all passing
added 2 commits
June 5, 2017 17:31
this method is used for line item level shipping which is not currently supported. a new task was created and the code can be re-added at that point. F51-313
amrarick26
approved these changes
Jun 6, 2017
crhistianramirez
pushed a commit
to crhistianramirez/angular-buyer
that referenced
this pull request
Jun 13, 2017
…ment no longer caching products, restricting roles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.