F51-152 Remove buyerid and catalogid constants#124
F51-152 Remove buyerid and catalogid constants#124crhistianramirez merged 4 commits intoordercloud-api:developmentfrom
Conversation
- This was stopping the order from being updated correctly in base.js - Use ocLineItems.AddItem() in the product card directive
- Update angular-bootstrap to the latest version, remove oc-carousel in favor of uib-carousel (custom directive was over-engineered) - Remove productSearch component in favor of re-routing the search directive to the product browse component. - Add an indicator when searching to the product browse template, there is also a blue icon for clearing the search (useful on mobile) - Move the product search modal into the ocProducts service in common/
|
This PR seems a little large because I added the package-lock.json file |
|
This will require a |
| }); | ||
| it('should resolve ProductList', function () { | ||
| xit('should resolve ProductList', function () { | ||
| injector.invoke(productsState.resolve.ProductList); |
There was a problem hiding this comment.
is this on purpose? xit will skip a test
There was a problem hiding this comment.
Yes, I haven't figured out how to stop the global parameters from changing during the unit tests. Some people are altering these for specific tests and those changes come down in subsequent tests. We may need to come up with a way to copy those parameters instead of changing what's stored in global.spec
There was a problem hiding this comment.
yeah, i noticed the same. Lets just add a function (can store it in global.spec.js) that does something similar to angular.copy so that global constants aren't mutated.
There was a problem hiding this comment.
that can be a separate task though
There was a problem hiding this comment.
3 participants
This also includes a lot of various changes based on an update that was made to the version of angular-bootstrap. Many of the changes account for the lack of
buyeridandcatalogidconstants.oc-carouselin favor ofuib-carousel(custom directive was over-engineered)ocProductsservice incommon/services/oc-products