F51-462, F51-275, F51-102 - add to cart validation & row flexing#125
Merged
olsonkr merged 3 commits intoordercloud-api:developmentfrom Jun 7, 2017
Merged
F51-462, F51-275, F51-102 - add to cart validation & row flexing#125olsonkr merged 3 commits intoordercloud-api:developmentfrom
olsonkr merged 3 commits intoordercloud-api:developmentfrom
Conversation
- Also, move the set default quantity functionality into the oc-quantity-input directive. - Remove the setDefaultQuantity function from oc-product-card
- Update oc-product-card to a directive so we can use the replace setting (true); this allows us to properly flex the product cards within a generic .row-flex class - Add a "size" attribute to oc-quantity-input, possible values: lg, md, sm, xs
Contributor
Author
|
Actual possible size values are "sm" and "lg" - I got it wrong in my commit message. |
Contributor
Author
|
I will be pushing one more task to this PR before re-opening |
robertsoniv
changed the title
crhistianramirez
previously requested changes
Jun 6, 2017
| templateUrl: 'common/directives/oc-product-card/oc-product-card.html', | ||
| controller: 'ProductCardCtrl', | ||
| controllerAs: 'productCard', | ||
| replace: true, |
Contributor
There was a problem hiding this comment.
This has been deprecated for a while now.
| require: '^?ocPrettySubmit', | ||
| templateUrl: 'common/directives/oc-quantity-input/oc-quantity-input.html', | ||
| replace: true, | ||
| link: function (scope) { |
Contributor
There was a problem hiding this comment.
It looks like it's only deprecated on 2.0+. We're still on 1.6.0.
Contributor
|
javascript looks ok except for the |
olsonkr
approved these changes
Jun 7, 2017
Contributor
Author
|
replace: true is what makes the styles work. without it I will have to change html. |
olsonkr
dismissed
crhistianramirez’s stale review
replace: true is still available in our version of angular
crhistianramirez
pushed a commit
to crhistianramirez/angular-buyer
that referenced
this pull request
Jun 13, 2017
…bineLIs F51-437 Combine Line Items
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commits for details.