Clean up for the product image display#139
Merged
spencerwalker merged 9 commits intoordercloud-api:developmentfrom Jun 20, 2017
Merged
Clean up for the product image display#139spencerwalker merged 9 commits intoordercloud-api:developmentfrom
spencerwalker merged 9 commits intoordercloud-api:developmentfrom
Conversation
spencerwalker
suggested changes
Jun 16, 2017
Contributor
spencerwalker
left a comment
spencerwalker
left a comment
There was a problem hiding this comment.
I'd like to minimize the inline styles, or at least have a better understanding of why they are necessary. Blocking the merge while I pull this down and poke at it a bit.
* minimize product detail images markup * clean up product detail images styles * begin to refactor full screen modal * add styles for lightbox modal F51-484
* scope styles for homepage slider * WIP: sync styles for carousel and slick sliders F51-484
* this will display the single image with same styles applied as an image in a carousel F51-484
* these have been refactored into a more generic full screen modal class f51-484
design: design for product detail image display
spencerwalker
approved these changes
Jun 20, 2017
amrarick26
pushed a commit
to amrarick26/angular-buyer
that referenced
this pull request
Jul 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are still some inline styles but I feel like this looks better than the originally merged styling. @spencerwalker I tried to get it all lumped into the LESS but unfortunately the slick carousel messes a few things up.