clean code#44
Merged
olsonkr merged 7 commits intoordercloud-api:developmentfrom Apr 21, 2017
Merged
Conversation
Contributor
crhistianramirez
commented
Apr 21, 2017
crhistianramirez
commented
- remove unnecessary product info get for each line item
- fix unit tests for cart
added 6 commits
April 21, 2017 07:59
product info is now a part of the line item object so we don’t need to get the product info separately
from gulp folders
this was causing on error on app-js task
olsonkr
suggested changes
Apr 21, 2017
Contributor
olsonkr
left a comment
olsonkr
left a comment
There was a problem hiding this comment.
Everything looks good. Since we don't need to get the Product data for a LineItem anymore, should we just remove that service method? I don't think it would be used/needed any where else, so we might as well remove the method at the same time we remove all of it's references.
no longer necessary as product info is stored directly on line items
amrarick26
approved these changes
Apr 21, 2017
olsonkr
approved these changes
Apr 21, 2017
crhistianramirez
pushed a commit
to culrich11/angular-buyer
that referenced
this pull request
May 2, 2017
…dresses DCR-30
robertsoniv
added a commit
to robertsoniv/angular-buyer
that referenced
this pull request
May 18, 2017
…eparation App structure separation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.