Unit tests & SDK updates#53
Merged
crhistianramirez merged 11 commits intoordercloud-api:developmentfrom May 3, 2017
Merged
Conversation
- We no longer have to load orderCloud or the SDK in every unit test file. They are now loaded for all tests in the src/ dir's global.spec.js file. - Started a global "mock" variable for reusing mock data across all unit tests. This should also clean up our test code a little. - Ignore *.spec.js in .eslintignore so that we don't see a ton of undefined variable errors - app.spec & base.spec have been updated to pass.
- version 1.0.49-staging-prerelease - updated all Me.GetProduct() calls to exclude catalogid as the first parameter; we should only need productID now.
- error handling should now work with the new OAuth error patterns
crhistianramirez
approved these changes
May 3, 2017
crhistianramirez
pushed a commit
to Four51/demo-angular-buyer
that referenced
this pull request
Aug 3, 2017
We were getting error message: too many redirects. Trying a different…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the OrderCloud Angular SDK to version 1.0.49-staging-prerelease
Error handling has been updated to account for the new OAuth error patterns
ex.response.body.error_descriptionUpdates to our unit test framework have been made to include global variables. This will greatly simplify each individual
*.spec.jsfile. See commit 15fc225Unit tests for the following have been completed: