chore: remove website/marketing code from public repo#27
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review SummaryAuthor: darshgupta-wisdm | +1 / -3,024 | 31 files changed | Vercel deploy: Ready This is a cleanup PR that removes all marketing/website pages from the public repo (preserved in Verdict: Looks good, with 2 issues to addressIssue 1: Missing redirect for unauthenticated users (Bug)The new const session = await auth();
if (session?.user?.id) {
redirect('/dashboard');
}
redirect('/login');This works, but the old code rendered a landing page for unauthenticated users. Now every visit to Issue 2: Remaining imports of deleted componentsVerify there are no other files importing from:
The PR only modifies files within Minor:
|
Full Review Report — PR #27chore: remove website/marketing code from public repo Verdict: APPROVE with required follow-upsThe deletion scope is clean — no broken imports, Vercel preview deploys successfully. However, 5 issues should be addressed before or shortly after merge. CRITICAL (1)C1. Orphaned static assets —
|
| # | Finding | Details |
|---|---|---|
| S1 | Logo creates circular navigation | Auth layout's <Logo href="/" /> now redirects back to /login. Consider pointing it to /login directly or rendering as non-interactive on auth pages. |
| S2 | /login indexable by search engines |
With / redirecting to /login and robots.ts allowing /, crawlers will index the login page. Add noindex meta if the app is not meant to be discoverable. |
| S3 | Sitemap returns 404 | sitemap.ts was deleted. If any external service (Google Search Console) references it, they'll get 404s. Consider purging from Search Console. |
| S4 | Spec file orphan | If specs/LANDING_PAGE_SPEC.md exists, it should be deleted alongside the code. |
What's Done Well
- Clean deletion — all 29 files removed consistently, no half-measures
- No broken imports — Vercel preview confirms successful build
- Clear PR rationale — explains the app/marketing split with
oreko-pro - Correct
robots.tsupdate — sitemap reference removed in sync withsitemap.tsdeletion
Summary Table
| Severity | Count | Action Required |
|---|---|---|
| CRITICAL | 1 | Delete orphaned images |
| IMPORTANT | 4 | Dead deps, stale middleware, redundant auth, legal pages |
| SUGGESTION | 4 | Logo link, SEO, sitemap, spec cleanup |
🤖 Full review generated with Claude Code using WisdmLabs Engineering Plugin workflow
|
Remaining item — I4 (Legal pages removed): Skipping for now. Flagging to Shubham to decide if legal pages (privacy/terms/cookies) need to live in the open source repo or only on the marketing site. Fixes pushed:
|
Review — Latest commit:
|
| # | Issue | Status |
|---|---|---|
| I4 | Legal pages (Privacy, Terms, Cookies) have no replacement in the public app | Needs confirmation — are these served from oreko-pro? If yes, we're good. If not, minimal standalone pages should be added. |
Verdict
Latest push looks good. Approve once I4 is clarified — confirm legal pages are accessible to users somewhere (either oreko-pro domain or re-added as standalone pages).
🤖 Reviewed with Claude Code
- Escape businessName in email layout template (Bug #27) - Add magic byte validation for file uploads to verify content type (Bug #30) - Add Cache-Control and X-Content-Type-Options to PDF downloads (Bug #65-66) - Escape user values in contract email template to prevent XSS (Bug #33) - Add Content-Security-Policy header to vercel.json (Bug #62) - Require CRON_SECRET for demo reset in production (Bug #55) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
apps/web/app/(marketing)/apps/web/components/landing/DotGrid.tsxandsitemap.ts/) now redirects to/loginWhy
The public
orekoapp/orekorepo should only contain app code. The website/marketing code is preserved inoreko-pro.Test plan
/redirects to/login🤖 Generated with Claude Code