Skip to content

feat(datasource): support external datasource urls#65

Merged
orellazri merged 8 commits intomainfrom
aviad/issue-32
Jun 28, 2024
Merged

feat(datasource): support external datasource urls#65
orellazri merged 8 commits intomainfrom
aviad/issue-32

Conversation

@aviadhaham
Copy link
Copy Markdown
Collaborator

still WIP, you can look if you want though :)
@orellazri

@aviadhaham aviadhaham self-assigned this Jun 23, 2024
Comment thread internal/datasources/web.go Outdated
Comment thread internal/datasources/toml.go Outdated
@aviadhaham
Copy link
Copy Markdown
Collaborator Author

@orellazri made some progress, as per our talk. pushed to have another check point.
I still need to create tests for web
and also see how I'm closing these files in createDatasourceFromURL func in parse.go

@aviadhaham
Copy link
Copy Markdown
Collaborator Author

@orellazri that's done, please check

Comment thread internal/datasources/web.go Outdated
Comment thread internal/datasources/web.go Outdated
Comment thread internal/datasources/web.go Outdated
@aviadhaham aviadhaham changed the title Support external data sources URLs (from the web) feat(datasource): support external datasource URLs Jun 28, 2024
@aviadhaham aviadhaham changed the title feat(datasource): support external datasource URLs feat(datasource): support external datasource urls Jun 28, 2024
@orellazri orellazri merged commit 24e5cd0 into main Jun 28, 2024
@orellazri orellazri deleted the aviad/issue-32 branch June 28, 2024 13:42
@aviadhaham aviadhaham linked an issue Jun 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support external data sources URLs (from the web)

2 participants