Skip to content

feat: add option for file glob patterns in 'exclude'#73

Merged
orellazri merged 7 commits intomainfrom
aviad/improve-exclusion
Jun 30, 2024
Merged

feat: add option for file glob patterns in 'exclude'#73
orellazri merged 7 commits intomainfrom
aviad/improve-exclusion

Conversation

@aviadhaham
Copy link
Copy Markdown
Collaborator

@aviadhaham aviadhaham commented Jun 29, 2024 •
edited
Loading

@orellazri done. please check

should close:
#72
#49

@aviadhaham aviadhaham self-assigned this Jun 29, 2024
This was linked to issues Jun 29, 2024
Check if can use a glob that's not path-aware #49
Closed
fix exclude not working when output is stdout #72
Closed
@aviadhaham
Copy link
Copy Markdown
Collaborator Author

aviadhaham commented Jun 30, 2024

made some improvements
now ready
@orellazri

btw, the glob library I used directly is one that goreleaser's fileglob lib depends on.
ref: github.com/gobwas/glob

orellazri
orellazri requested changes Jun 30, 2024
View reviewed changes
Comment thread internal/app/render.go Outdated
Comment thread internal/app/render.go Outdated
Comment thread internal/app/render.go Outdated
@orellazri orellazri merged commit 8dc92e4 into main Jun 30, 2024
@orellazri orellazri deleted the aviad/improve-exclusion branch June 30, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orellazri orellazri orellazri requested changes

Assignees

@aviadhaham aviadhaham

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix exclude not working when output is stdout Check if can use a glob that's not path-aware

2 participants

@aviadhaham @orellazri