Skip to content

Update Highlighter to work with Demeo 1.39.#545

Merged
TheGrayAlien merged 1 commit intomainfrom
eo/1.39-highlighter-1
Jun 8, 2025
Merged

Update Highlighter to work with Demeo 1.39.#545
TheGrayAlien merged 1 commit intomainfrom
eo/1.39-highlighter-1

Conversation

@orendain
Copy link
Owner

@orendain orendain commented Jun 8, 2025

Updates Highlighter to work with Demeo 1.39.

Additional changes:

  • Renames some variables (e.g., currentPiece) to make it more clear what they're used for.
  • Adds some better comments to code.
  • Extract the ability which is used to compute the highlight distance rendered.

Note

@orendain tested this on PC Edition, but has not yet tested it on Steam VR or Quest VR. If needed, he can test that platform after a few other changes are merged in.

Note

@orendain will update the build CI in a subsequent PR so that the build does not consistently fails on GitHub. For now, this is built/tested locally.

@orendain orendain self-assigned this Jun 8, 2025
@github-actions github-actions bot added the area: highlighter The Highlighter mod label Jun 8, 2025
@orendain orendain added the type: feature New feature, enhancement or request label Jun 8, 2025
@orendain orendain marked this pull request as ready for review June 8, 2025 06:16
@orendain orendain requested a review from TheGrayAlien June 8, 2025 06:16
Copy link
Collaborator

@TheGrayAlien TheGrayAlien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@TheGrayAlien TheGrayAlien merged commit 2a4c0ae into main Jun 8, 2025
1 of 2 checks passed
@TheGrayAlien TheGrayAlien deleted the eo/1.39-highlighter-1 branch June 8, 2025 06:44
TheGrayAlien added a commit that referenced this pull request Jun 8, 2025
> [!NOTE]
> Please review / merge #545
first.

---

Increases line of sight distance rendered. Specifically, uses the
`HunterArrow` to decide the distance rendered (which is longer than the
previous `MagicMissle`).

> [!NOTE]
> @orendain will update the build CI in a subsequent PR so that the
build does not consistently fails on GitHub. For now, this is
built/tested locally.

---------

Co-authored-by: The Gray Alien <103865052+TheGrayAlien@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: highlighter The Highlighter mod type: feature New feature, enhancement or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants