Maintenance/upgrade go and fix linter issues#162
Merged
orgrim merged 8 commits intoorgrim:masterfrom Apr 21, 2026
Merged
Conversation
Unfortunately multiple IPv6 hosts no longer with net/url Parse() func, so may be we should implement our own connection URI parser.
io/ioutil is deprecated since golang 1.16
and fix issue on the test case for b2 implementation.
- Remove useless usage of fmt.Sprintf() - Fix ineffassign - Use implicit bool type - Remove useless break - Remove useless blank assignation - Fix errors formatting (punctuation, newline,...) - Use ReplaceAll instead of Replace (with -1) - Use case instead of long if, else if, else
Introduce a WrappedClose() helper to properly propagate Close() errors when using defer, avoiding silent error loss during cleanup. Refactor to: - Use named return errors to allow deferred error propagation - Replace direct defer Close() calls with WrappedClose - Ensure Close() errors are not ignored (notably for writers like age) - Return accumulated errors instead of discarding them Also: - Fix unchecked fmt.Fprintf errors - Make cleanup paths more explicit when removing files after failure - Improve test by checking errors in deferred cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit is for upgrading Go to the latest version; the others are initial work to introduce
golangci-lintandgolines. If needed, I can split this MR into two separate ones.