Suggestion: [Naming] IsValidAsync is not an async function #612
Unanswered
Coldknife2
asked this question in
BFF
Replies: 2 comments
|
Hey @Coldknife2, just wanted to let you know that we've discussed this with our engineers. We're still evaluating whether the method should indeed be renamed to be synchronous, or that the method should become asynchronous again. |
0 replies
|
Thank you for reporting this. During the development of V4, we went back and forth a couple of times thinking if we wanted to make this async or not. Unfortunately it ended up somewhere in the middle. We've put it on our backlog to be picked up soon. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Hello, just upgraded duende bff from v3 to v4 and found this function
IReturnUrlValidator.IsValidAsync
https://github.com/DuendeSoftware/products/blob/6f895793e6e26ce397c743d3bf1f9dc8ff8e732d/bff/src/Bff/Endpoints/IReturnUrlValidator.cs#L15
https://github.com/search?q=repo%3ADuendeSoftware%2Fproducts+IsValidAsync&type=code
It was async then, diff: DuendeSoftware/products@3721b63#diff-43da3df752f9dc4c98eac28f16d7fb29cc817c25ff3dc5e1176c2ae5ad796e3a
But it seems it's not the case anymore.
All reactions