(1.21.5) Problem registering armor trim material and pattern

[Lea-Reift]

Description

Greetings. I recently started mod development, and I started with fabric. I'm studying it with Kaupenjoe's video series (intended for version 1.21.1, although there were breaking changes, the syntax is almost the same). I tried to register custom armor trim pattern and material, but I got two issues:

• The new material is not recognized in the smithing table.
  

• The pattern breaks the texture of the in game armor item.
  

Any ideas? Also, I have the textures for the trim template, but maybe they are in the wrong folders for this version.
The armor models are in resources/assets/tutorialmod/textures/trims/models/armor and the color_palettes in resources/assets/tutorialmod/textures/trims/color_palettes . Source code below.

Smithing Template registration:

public static final Item KAUPEN_SMITHING_TEMPLATE = registerItem(
            "kaupen_armor_trim_smithing_template",
            SmithingTemplateItem.of(new Item.Settings()
                    .trimMaterial(ModTrimMaterials.PINK_GARNET)
                    .requires(FeatureFlags.VANILLA)
                    .registryKey(getItemRegistryKey("kaupen_armor_trim_smithing_template"))
            )
 );

Add item to TRIM_MATERIALS tag:

 getOrCreateTagBuilder(ItemTags.TRIM_MATERIALS)
        .add(ModItems.PINK_GARNET);

Model DataGen registration:

itemModelGenerator.register(ModItems.KAUPEN_SMITHING_TEMPLATE, Models.GENERATED);

Recipe DataGen registration:

offerSmithingTrimRecipe(
                ModItems.KAUPEN_SMITHING_TEMPLATE,
                RegistryKey.of(RegistryKeys.TRIM_PATTERN, TutorialMod.getIdentifierForModAsset("kaupen")),
                RegistryKey.of(
                RegistryKeys.RECIPE,
                        Identifier.ofVanilla(
                       RecipeGenerator.getItemPath(ModItems.KAUPEN_SMITHING_TEMPLATE) + "_smithing_trim"
                )
        )
        );

Registry DataGen declaration:

import net.fabricmc.fabric.api.datagen.v1.FabricDataOutput;
import net.fabricmc.fabric.api.datagen.v1.provider.FabricDynamicRegistryProvider;
import net.minecraft.registry.RegistryKeys;
import net.minecraft.registry.RegistryWrapper;

import java.util.concurrent.CompletableFuture;

public class ModRegistryDataGenerator extends FabricDynamicRegistryProvider {

    public ModRegistryDataGenerator(FabricDataOutput output, CompletableFuture<RegistryWrapper.WrapperLookup> registriesFuture) {
        super(output, registriesFuture);
    }

    @Override
    protected void configure(RegistryWrapper.WrapperLookup wrapperLookup, Entries entries) {
        entries.addAll(wrapperLookup.getOrThrow(RegistryKeys.TRIM_MATERIAL));
        entries.addAll(wrapperLookup.getOrThrow(RegistryKeys.TRIM_PATTERN));
    }

    @Override
    public String getName() {
        return this.getClass().getName();
    }
}

TrimMaterials declaration:

import com.leareift.tutorialmod.TutorialMod;
import net.minecraft.item.equipment.trim.ArmorTrimAssets;
import net.minecraft.item.equipment.trim.ArmorTrimMaterial;
import net.minecraft.registry.Registerable;
import net.minecraft.registry.RegistryKey;
import net.minecraft.registry.RegistryKeys;
import net.minecraft.text.Style;
import net.minecraft.text.Text;
import net.minecraft.text.TextColor;
import net.minecraft.util.Util;

public class ModTrimMaterials {

    public static final RegistryKey<ArmorTrimMaterial> PINK_GARNET = RegistryKey.of(
            RegistryKeys.TRIM_MATERIAL,
            TutorialMod.getIdentifierForModAsset("pink_garnet")
    );

    public static void bootstrap(Registerable<ArmorTrimMaterial> registerable) {
        register(
                registerable,
                ModTrimMaterials.PINK_GARNET,
                Style.EMPTY.withColor(TextColor.parse("#b03fe0").getOrThrow())
        );
    }

    private static void register(
            Registerable<ArmorTrimMaterial> registerable,
            RegistryKey<ArmorTrimMaterial> armorTrimKey,
            Style style
    ) {
        ArmorTrimMaterial trimMaterial = new ArmorTrimMaterial(
                ArmorTrimAssets.of(armorTrimKey.getValue().getPath()),
                Text.translatable(Util.createTranslationKey("trim_material", armorTrimKey.getValue())).fillStyle(style)
        );

        registerable.register(armorTrimKey, trimMaterial);
    }
}

TrimPattern declaration:

package com.leareift.tutorialmod.trim;

import com.leareift.tutorialmod.TutorialMod;
import net.minecraft.item.equipment.trim.ArmorTrimPattern;
import net.minecraft.registry.Registerable;
import net.minecraft.registry.RegistryKey;
import net.minecraft.registry.RegistryKeys;
import net.minecraft.text.Text;
import net.minecraft.util.Util;

public class ModTrimPatterns {

    public static final RegistryKey<ArmorTrimPattern> KAUPEN = RegistryKey.of(
            RegistryKeys.TRIM_PATTERN,
            TutorialMod.getIdentifierForModAsset("kaupen")
    );

    public static void bootstrap(Registerable<ArmorTrimPattern> context) {
        register(context, KAUPEN);
    }

    private static void register(Registerable<ArmorTrimPattern> context, RegistryKey<ArmorTrimPattern> key) {
        ArmorTrimPattern trimPattern = new ArmorTrimPattern(
                key.getValue(),
                Text.translatable(Util.createTranslationKey("trim_pattern", key.getValue())),
                false
        );

        context.register(key, trimPattern);
    }
}

DataGenerator initializer:

package com.leareift.tutorialmod;

import com.leareift.tutorialmod.datagen.*;
import com.leareift.tutorialmod.trim.ModTrimMaterials;
import com.leareift.tutorialmod.trim.ModTrimPatterns;
import net.fabricmc.fabric.api.datagen.v1.DataGeneratorEntrypoint;
import net.fabricmc.fabric.api.datagen.v1.FabricDataGenerator;
import net.minecraft.registry.RegistryBuilder;
import net.minecraft.registry.RegistryKeys;

public class TutorialModDataGenerator implements DataGeneratorEntrypoint {
	@Override
	public void onInitializeDataGenerator(FabricDataGenerator fabricDataGenerator) {
		FabricDataGenerator.Pack pack = fabricDataGenerator.createPack();

		pack.addProvider(ModBlockTagProvider::new);
		pack.addProvider(ModItemTagProvider::new);
		pack.addProvider(ModLootTableProvider::new);
		pack.addProvider(ModModelProvider::new);
		pack.addProvider(ModRecipeProvider::new);
		pack.addProvider(ModRegistryDataGenerator::new);
	}

	@Override
	public void buildRegistry(RegistryBuilder registryBuilder) {
		registryBuilder.addRegistry(RegistryKeys.TRIM_MATERIAL, ModTrimMaterials::bootstrap);
		registryBuilder.addRegistry(RegistryKeys.TRIM_PATTERN, ModTrimPatterns::bootstrap);
		DataGeneratorEntrypoint.super.buildRegistry(registryBuilder);
	}
}

[Strange-Quark-007]

To answer your 1st question

• The new material is not recognized in the smithing table

When registering item which you want to use as trim, you need to call .trimMaterial(ModTrimMaterials.PINK_GARNET) on its Item.Settings

for eg:

new Item.Settings().trimMaterial(ModTrimMaterials.PINK_GARNET)

and also add item to ItemTags.TRIM_MATERIALS (which you are already doing)

And for the textures it's a bit tricky to get right because of folder structure changes. I suggest checking out my implementation in this branch where I’ve successfully set up for Minecraft 1.21.5.

I stumbled upon this post while trying to solve the same issues myself. With the significant changes in 1.21.4+ and almost no documentation for 1.21.5, it’s definitely a rough ride.

[Gigglestomp]

I got the second issue fixed but not the first. I can use the template fine with stuff like lapis on iron armor. I think it fixed it when I updated the location in armor_trims.json
Should look like this:
"trims/entity/humanoid/bolt",
"trims/entity/humanoid_leggings/bolt",
"tutorialmod:trims/entity/humanoid/kaupen",
"tutorialmod:trims/entity/humanoid_leggings/kaupen"

Did you ever get the first issue fixed? I am trying to solve it now. I can't use the pink_garnet for the trim material but it does let me put it in the smithing table.

[Gigglestomp]

Wait! I got it working! It isn't showing the pink_garnet trim on the iron armor in the inventory BUT it works and you can wear it.

Go up to the top of ModItems and update the original pink_garnet line to add .trimMaterial

public static final Item PINK_GARNET=registerItem("pink_garnet",new Item(new Item.Settings()
.trimMaterial(ModTrimMaterials.PINK_GARNET)
.registryKey(RegistryKey.of(RegistryKeys.ITEM, Identifier.of(TutorialMod.MOD_ID,"pink_garnet")))));

[SuperGamerBird123]

Ya'll are the best, can confirm that it still works in 1.21.11!

[TheElementGuy]

I don't know if this will help any of you, but you may need to update the texture atlases for the items.
For the item, use:
src/main/resources/assets/minecraft/atlases/items.json

{
  "sources": [
    {
      "type": "minecraft:directory",
      "prefix": "item/",
      "source": "item"
    },
    {
      "type": "minecraft:paletted_permutations",
      "palette_key": "minecraft:trims/color_palettes/trim_palette",
      "permutations": {
        "amethyst": "minecraft:trims/color_palettes/amethyst",
        "copper": "minecraft:trims/color_palettes/copper",
        "copper_darker": "minecraft:trims/color_palettes/copper_darker",
        "diamond": "minecraft:trims/color_palettes/diamond",
        "diamond_darker": "minecraft:trims/color_palettes/diamond_darker",
        "emerald": "minecraft:trims/color_palettes/emerald",
        "gold": "minecraft:trims/color_palettes/gold",
        "gold_darker": "minecraft:trims/color_palettes/gold_darker",
        "iron": "minecraft:trims/color_palettes/iron",
        "iron_darker": "minecraft:trims/color_palettes/iron_darker",
        "lapis": "minecraft:trims/color_palettes/lapis",
        "netherite": "minecraft:trims/color_palettes/netherite",
        "netherite_darker": "minecraft:trims/color_palettes/netherite_darker",
        "quartz": "minecraft:trims/color_palettes/quartz",
        "redstone": "minecraft:trims/color_palettes/redstone",
        "resin": "minecraft:trims/color_palettes/resin",
        "pink_garnet": "yourmodid:trims/color_palettes/pink_garnet"
      },
      "textures": [
        "minecraft:trims/items/helmet_trim",
        "minecraft:trims/items/chestplate_trim",
        "minecraft:trims/items/leggings_trim",
        "minecraft:trims/items/boots_trim"
      ]
    }
  ]
}