SponsorCheck integration in v33 questions/feedback

[martincostello]

Two pieces of feedback on the SponsorCheck integration in Verify v33:

1. Is there a missing SponsorshipExemption type for a generic "open source" project? We're using Verify in Swashbuckle.AspNetCore, which I wouldn't really consider to be SmallRevenue - it's MIT-licensed and essentially free and doesn't generate revenue, other than having a GitHub Sponsors link for goodwill donations. We similarly use Verify in the OpenTelemetry .NET SDK, and that doesn't generate revenue and doesn't have GitHub Sponsors. I would consider free/$0 to be distinct from "less than USD 10,000" (even if mathematically 0 < 10000).

2. How do I completely suppress the SC031 warning? I've tried both NoWarn="SC031" on the CPM PackageVersion item, the PackageReference items and <NoWarn>$(NoWarn);SC031</NoWarn> in Directory.Build.props, but in all cases I still get the following warning:

Swashbuckle.AspNetCore.SwaggerGen.Test net8.0 succeeded with 1 warning(s) (1.2s) → artifacts\bin\Swashbuckle.AspNetCore.SwaggerGen.Test\debug_net8.0\Swashbuckle.AspNetCore.SwaggerGen.Test.dll
    D:\packages\nuget\verify\33.0.0-beta.7\buildTransitive\Verify.targets(86,5): SponsorCheck warning SC031:
      Exemption claimed. Package 'Verify': Verify_SponsorshipExemption="SmallRevenue" property is set until 2027-09. Publisher's exemption criteria: Consumers under US$10,000 annual gross revenue are exempt.

      See: https://github.com/SimonCropp/SponsorCheck/blob/main/docs/VerifierDiagnosticCodes.md#sc031

I don't want to see any warnings in the build output whatsoever.

[SimonCropp]

@martincostello

1. Open source exemption. Agreed that $0 is a different thing from "under US$10,000". 33.0.0-beta.8 adds an OpenSource exemption alongside SmallRevenue and MaintainerConsulting. Its criteria: "Open source projects that do not generate revenue are exempt. Voluntary donations and sponsorships are not revenue." That wording follows the OSMF consumer FAQ, so a GitHub Sponsors link for goodwill donations does not count as revenue. Claim it with:

<PropertyGroup>
  <Verify_SponsorshipExemption>OpenSource</Verify_SponsorshipExemption>
  <Verify_SponsorshipExemptionUntil>2027-09</Verify_SponsorshipExemptionUntil>
</PropertyGroup>

The end month can be at most 12 months out. Docs: https://github.com/VerifyTests/Verify/blob/main/docs/maintenance-fee.md#exempt

2. Suppressing SC031. in your NoWarns are you ensuring each level inherits the parent? eg <NoWarn>$(NoWarn);...</NoWarn>

[martincostello]

1. Thanks.
2. Sorry my mistake, turns out there was exactly one project that didn't inherit the existing NoWarn value, and it was a project that happened to use Verify, so the D.B.props override was being lost.