Filter inline autofill suggestions by the text typed into the username field #23939
crrylx
started this conversation in
Password Manager
Replies: 1 comment
|
✨ Thank you for your code contribution proposal! While the Bitwarden team reviews your submission, we encourage you to check out our contribution guidelines. Please ensure that your code contribution includes a detailed description of what you would like to contribute, along with any relevant screenshots and links to existing feature requests. This information helps us gather feedback from the community and Bitwarden team members before you start writing code. To keep discussions focused, posts that do not include a proposal for a code contribution will be removed.
Thank you for contributing to Bitwarden! |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Select Topic Area
✅ Code Contribution Proposal
Code Contribution Proposal
Problem
In organizations, one site can match many logins. We run Vaultwarden with ~200 Microsoft 365 accounts that all match
login.microsoftonline.com. The inline autofill menu lists every match and ignores what is typed into the username field, so picking the right account means scrolling a long list or opening the popup to search.Proposed code contribution
While typing into a login username field, narrow the inline menu list to logins whose username or item name contains the typed text (case-insensitive).
Implementation plan
Changes are limited to
apps/browser/src/autofill:autofill-overlay-content.service.ts: on trusted input in a login username field, send the value to the background (updateAutofillInlineMenuListFilter) instead of closing the list.overlay.background.ts: store the filter, skip non-matching login ciphers inbuildInlineMenuCiphers, and refresh (or open) the inline menu list; reset the filter when focus moves to another form or tab.A working version with unit tests already exists and has been in daily use on our team. I've signed the CLA. Open to feedback on the UX, e.g. matching on username only, or putting it behind a setting.
Related
Feature request on the community forum: https://community.bitwarden.com/t/inline-autofill-menu-ability-to-filter-items-by-typing-searching/63417
Pull request: #23940
All reactions