Pull Requests missing from milestones

[cvergne]

🏷️ Discussion Type

Bug

Body

Hi,
For the past few days, there has been a syncing issue with milestones.
If I add a milestone to a pull request, then go to the milestone page, the pull request doesn't appear in the list. The same happens if I use the API to get PRs filtered by milestone, the PR is missing.
PRs attached before this week are displayed correctly and returned by API.

I've tried everything to "force sync":

• Removing / adding the milestone on the pull request
• Changing to another milestone, then back to the correct one
• Closing / reopening the milestone
• Updating the milestone (title, date)

Nothing works, and the problem occurs on different private repositories, with different milestones and pull requests.

Can you please take a look?

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐

[xusnitdinov]

Yeah this sounds like a real indexing/sync bug on GitHub's side, not something wrong with how you're attaching milestones.

A couple of notes from similar cases:

• The milestone page and the Issues/PR search (milestone:"Name" or the REST milestone filter) both read from the same search index. If a PR shows the milestone in the sidebar but doesn't show up on the milestone page or via the API, the write path succeeded and the index didn't catch up.
• Your force-sync attempts (remove/add, close/reopen, edit title/date) are exactly the right things to try. If none of those brought it back, the indexer is stuck for those newer associations.

Workarounds that sometimes kick it loose:

1. Temporarily change the PR's base branch (or make a tiny empty commit / push) so the PR gets a fresh update event.
2. Use the GraphQL API to clear and re-set the milestone in one mutation, which can fire a different event than the UI:

mutation {
  updatePullRequest(input: {pullRequestId: "PR_NODE_ID", milestoneId: null}) {
    pullRequest { id }
  }
}

then set it again with the real milestoneId.

If that still doesn't surface them, this needs GitHub Support. Open a ticket at https://support.github.com/ and include: repo names (even private is fine for support), milestone titles, a couple of PR numbers that are missing, and that both the UI and the REST filter are empty while older PRs still show. That's enough for them to check the search index for those associations.

Happy to look at a public repro if you have one, but from what you described this is almost certainly on their end.

[cvergne]

I've opened a support ticket yesterday, and they confirmed they have an internal ticket about it on their side ;)

[xusnitdinov]

Good to hear Support confirmed it - hope the index fix lands soon :D

[AkihiroSuda]

We are hitting the same issue in https://github.com/lima-vm/lima

1. Temporarily change the PR's base branch (or make a tiny empty commit / push) so the PR gets a fresh update event.
2. Use the GraphQL API to clear and re-set the milestone in one mutation, which can fire a different event than the UI:

1 seems to work for us. 2 didn't.