User access token refresh and reset should be more consistent #206564
Unanswered
xmo-odoo
asked this question in
Apps, API and Webhooks
Replies: 1 comment
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
🏷️ Discussion Type
Product Feedback
💬 Feature/Topic Area
Apps
Body
This would be especially useful now that oauth apps have been updated to support expiring tokens
reset
Resetting a token returns a lot of authorization metadata, but even though it looks useful it's useless for expiring UATs because it doesn't bump the
expires_at, it just updates the token (andupdated_at) on the installation. So this endpoint is only useful to force the rotation of non-expiring user access tokens, if you're using expiring tokens (which is clearly the future as far as github is concerned) you might as well refresh the token immediately.Resetting a token should either bump the
expires_at(it still requires a valid UAT anyway, and does not affect therefresh_token), or be clearly documented as useless / deprecated for expiring UATs.refresh
Refreshing a token does bump
expires_at, and rotates therefresh_token, however unlikeresetit only returns the lifetime of the two values, it doesn't return the actual expiry times. This makes the expiry information a lot less convenient in many cases as the caller has to processexpires_inandrefresh_token_expires_inquickly, and is more constrained on its clock drift wrt github.Even though that is not part of the oauth standard for some fool reason, it would be really nice if github could return the
expires_atandrefresh_token_expires_atvalues when refreshing a token.All reactions