GraphQL public schema fails graphql-js 17 validation: deprecated implementation fields on non-deprecated interface fields

[blimmer]

GitHub's public GraphQL schema (https://docs.github.com/public/fpt/schema.docs.graphql) fails schema validation in graphql-js 17. Version 17 added a rule: if an interface field isn't deprecated, a type implementing that interface can't deprecate its copy of the field. GraphQL Code Generator and gql.tada both validate the schema they load, so on graphql 17 they reject GitHub's schema and stop.

With graphql@17.0.2, the current schema has 8 errors:

Interface field Node.id is not deprecated, so implementation field Project.id must not be deprecated.
Interface field Node.id is not deprecated, so implementation field ProjectCard.id must not be deprecated.
Interface field Node.id is not deprecated, so implementation field ProjectColumn.id must not be deprecated.
Interface field Reactable.databaseId is not deprecated, so implementation field PullRequest.databaseId must not be deprecated.
Interface field Reactable.databaseId is not deprecated, so implementation field PullRequestReview.databaseId must not be deprecated.
Interface field Reactable.databaseId is not deprecated, so implementation field PullRequestReviewComment.databaseId must not be deprecated.
Interface field Subscribable.viewerCanSubscribe is not deprecated, so implementation field Team.viewerCanSubscribe must not be deprecated.
Interface field Subscribable.viewerSubscription is not deprecated, so implementation field Team.viewerSubscription must not be deprecated.

To reproduce:

import { buildSchema, validateSchema } from 'graphql'; // 17.0.2

const sdl = await (await fetch('https://docs.github.com/public/fpt/schema.docs.graphql')).text();
console.log(validateSchema(buildSchema(sdl, { assumeValidSDL: true })).map((e) => e.message));

All eight deprecated fields are past the removal dates in their deprecation reasons: Project.id and the other Projects (classic) fields on 2025-04-01, databaseId on 2024-07-01, and the Team subscription fields on 2026-07-01.

Any of these would fix it:

• Remove the fields, since their removal dates have passed.
• Drop @deprecated from the implementing field and move the notice into the field's description.
• Deprecate the interface field as well, if it's going away for every implementing type.

Someone else hit the same errors in July: 0no-co/gql.tada#574. For now we're working around it by turning off schema validation in codegen (assumeValid: true).

[github-actions[bot]]

Thank you for your interest in contributing to our community! We currently only accept discussions created through the GitHub UI using our provided discussion templates. Please re-submit your discussion by navigating to the appropriate category and using the template provided.

This discussion has been closed because it was not submitted through the expected format. If you believe this was a mistake, please reach out to the maintainers.

[blimmer]

Opened https://github.com/orgs/community/discussions/210386