Show the ruleset bypass justification on the pull request #210756
Unanswered
emilras
asked this question in
Pull Requests
Replies: 1 comment
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
🏷️ Discussion Type
Product Feedback
Body
When a user with bypass permissions merges a pull request that doesn’t meet ruleset requirements (for example, a missing approving review), the merge dialog shows an extended description field. In practice, this is where people write why they’re bypassing the rules.
That text becomes the body of the merge commit message. Having it in the merge commit makes sense. The problem is that the merge commit is the only place it ends up:
Pull request timeline: it shows “merged commit into ”, with no sign that rules were bypassed and no justification.
Audit log: the protected_branch.policy_override event records the actor, branch and overridden rule (review_policy_not_satisfied), but not the reason given.
Rule suites REST API: it returns result: bypass and the rule evaluations, but has no field for a reason.
So the justification is separated from the thing it justifies. Anyone looking at the PR later, such as a reviewer, a teammate or an auditor, has no way of seeing that rules were bypassed or why, unless they know to go and find the merge commit.
Request
Why
Many teams need to justify and periodically review exceptions to branch protection for compliance. The PR is the natural record of a change, so the evidence that its review requirements were bypassed, and why, should live there too.
Related: https://github.com/orgs/community/discussions/205777
All reactions