Pull requests: Saved whitespace preferences and improved split view

[moraesc]

We’ve made two updates to make reviewing pull requests in the Files changed page easier:

1. Save your whitespace preference across pull requests.

In Settings → Whitespace changes, choose Always show, Always hide, or Hide for this diff only. Your preference is personal and applies across pull requests.

When whitespace is hidden, use the X beside Hide whitespace to temporarily show it without changing your saved setting.

2. Get more room to review new and deleted files in split view. These files now span both columns, as they do in unified view, reducing line wrapping and making the content easier to read.

We’d love to hear what you think. Share your questions or feedback in the comments!

[aaronhipple]

Save your whitespace preference across pull requests.

Love this! This has been my number 1 gripe with the PR review UI for years now, so I'm very happy to see this change.

Get more room to review new and deleted files in split view. These files now span both columns, as they do in unified view, reducing line wrapping and making the content easier to read.

I absolutely HATE this. Really disruptive when scanning a file's additions from top to bottom. The whole point of split view is that new things go on the right, deleted things go on the left -- a paradigm that's now broken. Why would anybody want this? Is it possible to restore the original behavior with a setting or similar? This is bad enough that it may force me to switch away from the GitHub web UI altogether for PR reviews.

(edit: And how did this pass accessibility review? I realize complete monochromatic colorblindness is pretty rare but wow -- having simulated that, it is really difficult to parse the difference between an addition & removal at a glance)