Huge HTTP header response sizes #211142
Replies: 6 comments
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
|
same issue 08:36:44.399 [debug] Downloading NIF from https://github.com/elixir-nx/explorer/releases/download/v0.13.0/libexplorer-v0.13.0-nif-2.15-x86_64-unknown-linux-gnu.so.tar.gz == Compilation error in file lib/explorer/polars_backend/native.ex == |
|
i dont know but dont giveup |
|
This issue also affects Perl standard CPAN library which has a default limit of 8192 (in code as 8*1024). A caller can override the default max ... but that brings the potential for a lot of code changes. |
|
This is obviously bad practice and there are many simple ways to resolve it. I haven’t personally run into an error case yet, but please fix this before I do. |
|
Echoing this issue, the Erlang httpc client no longer working due to the header sizes when downloading binaries from GitHub releases has broken dependency management for all of our Elixir repos, breaking all of our CI. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
🏷️ Discussion Type
Bug
💬 Feature/Topic Area
API
Body
When running
curl -sILD - -o /dev/null "https://github.com/ash-project/igniter_js/releases/download/v0.5.0/libigniter_js-v0.5.0-nif-2.15-x86_64-unknown-linux-gnu.so.tar.gz"you'll notice that you get over 11KiB of HTTP response headers.This breaks things like Elixir :httpc which errors out with
{:header_too_long, {:max, 10240}}}.The "content-security-policy" for example contains
...productionresultssa1.blob.core.windows.net ... productionresultssa199.blob.core.windows.net.This is a bit ridiculous tbh, and causes other ecosystems that have made reasonable assumptions to break. Please limit the sizes of your HTTP response headers.
Instead of hundreds of
productionresultssa173.blob.core.windows.netentries - maybe aproductionresults.githubusercontent.comentry or similar?!All reactions