Docker service image uses latest version instead of the specified one

[petersg83]

Select Topic Area

Bug

Body

Hello :)

First of all, I don't know a lot about github actions. So maybe there is an obvious thing I don't see :)

Summary
I try to run tests on MySQL version 5 but it apparently runs with MySQL version 8 (latest). I discovered that by handling a test that should have failed with v5 but didn't.

Is it a bug, or is the config wrong?

Details
As you can see in this logs https://github.com/strapi/strapi/actions/runs/3478068012/jobs/5816050634
(in Initialize container > Starting mysql service container), the MySQL image is pulled twice (line 16 and line 70).
Once for the version I'm targeting (5.7.8) and once for the latest version. I don't understand why the latest is pulled and, from what I understand, used.

You can see the github action config there: https://github.com/strapi/strapi/blob/fix/github-test-mysql5/.github/workflows/tests.yml.
An extract of the workflow:

  api_ce_mysql_5:
    runs-on: ubuntu-latest
    needs: [lint, unit_back, unit_front]
    name: '[CE] API Integration (mysql:5 , node: ${{ matrix.node }})'
    strategy:
      matrix:
        node: [14, 16, 18]
    services:
      mysql:
        image: mysql:5.7.8
        options: >-
          --health-cmd="mysqladmin ping"
          --health-interval=10s
          --health-timeout=5s
          --health-retries=3
          -e MYSQL_ROOT_PASSWORD=strapi
          -e MYSQL_ROOT_HOST="%"
          -e MYSQL_USER=strapi
          -e MYSQL_PASSWORD=strapi
          -e MYSQL_DATABASE=strapi_test
          --entrypoint sh mysql -c "exec docker-entrypoint.sh mysqld --default-authentication-plugin=mysql_native_password"
        ports:
          # Maps tcp port 5432 on service container to the host
          - 3306:3306
    steps:
      - uses: actions/checkout@v2
      - uses: actions/setup-node@v2
        with:
          node-version: ${{ matrix.node }}
          cache: yarn
      - uses: ./.github/actions/install-modules
      - uses: ./.github/actions/run-api-tests
        with:
          dbOptions: '--dbclient=mysql --dbhost=localhost --dbport=3306 --dbname=strapi_test --dbusername=strapi --dbpassword=strapi'

Related PR

strapi/strapi#14878

[david-engelmann]

Here is a list of all the supported tags for mysql images:

8.0.31, 8.0, 8, latest, 8.0.31-oracle, 8.0-oracle, 8-oracle, oracle
8.0.31-debian, 8.0-debian, 8-debian, debian
5.7.40, 5.7, 5, 5.7.40-oracle, 5.7-oracle, 5-oracle
5.7.40-debian, 5.7-debian, 5-debian

Try to run the action using one of these tags

[petersg83]

Thank you for your answer! Indeed I'm not using one of this versions in my PR.
However the problem was already previously identified with the image mysql:5.

I will rollback to mysql:5 to be sure to use one of the correct versions.

[ChristopherHX]

The actions/runner doesn't sanitize your options.

The docker option entrypoint takes one argument, but you provided 4 arguments.

--entrypoint sh mysql -c "exec docker-entrypoint.sh mysqld --default-authentication-plugin=mysql_native_password"

Docker now interprets mysql from your entrypoint as the image name for docker create..., the default tag latest is used because your misparsed mysql image name has no tag.
Interesting to see that this job passed, including this input error.

[petersg83]

Thank you! Indeed, I modified some things around the entrypoint and it seems to work better now!

[petersg83]

If people come by, in the end, based on that discussion : https://stackoverflow.com/questions/60902904/how-to-pass-mysql-native-password-to-mysql-service-in-github-actions I used bitnami/mysql images instead of mysql. It's easier to pass some options.