Merge queue and required status checks

[SaraRavasio]

Select Topic Area

Bug

Body

I have set up merge queue for one of my repositories.
In this repository, I have some required status checks that need to pass in order to be able to merge.

Required status:

• mergefreeze
• lintin
• test coverage

In merge queue:

• cypress tests

The required gh actions pass before merging, but when I start the merge queue and my cypress tests pass, I still see the merge queued due to the requirements for these 3 actions to pass, but they're not even triggered.

[ossanna16]

Hi there @SaraRavasio and welcome to our community! Thank you for reporting this bug!

[mrmckeb]

Hi there, you need to use the merge_group event:
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#merge_group

We hit this too, it's a strange one - but I think the idea is that they want you to be able to know when something is running in a pull_request vs merge_group.

[rabbiveesh]

oh; i didn't read carefully enough. You're right, if I add synchronize and an if check like you have, then it would run on every push.

Thanks!

[SaraRavasio]

@kiajfaty yes, I tried to use merge_group, but without success :/

[rabbiveesh]

@SaraRavasio new problem; when a job is skipped, it counts as sucess, so you have nothing forcing you to actually run the cypress test in the PR

[SaraRavasio]

@rabbiveesh good point, another very annoying (in my opinion) bug on their side.

This is how I overcome this problem:

• in my cypress dashboard I've added a board connected to my repository

• if you do that and run again cypress, you'll see that one of the required status check that you have available now is cypress: default-group, use that one

• it will always stay in "loading" state until you run your tests, and this means you can't merge your pr

Let me know if it works for you :)

[rabbiveesh]

ah, that works for cypress; i'm doing a couple of other things.

In the end, i rewrote my pre-master tests to be a reusable workflow, so they won't get called at all if the workflow is in the wrong state, thus never getting skipped, b/c the skip just keeps them from getting called.

I also don't have the requirement to be up to date w/ master, b/c I run the tests again in the merge queue, so even if in theory there's a race condition where the PR gets auto-merged before the workflow call hits (don't know if that happens), it'll end up getting tested on master.

Obviously, that's not an option for cypress (my cypress test suite takes 10 minutes 😢 ), but it's a useful thing nonetheless