Permissions for Approving Pull Requests

[dwmarshall]

Select Topic Area

Product Feedback

Body

As a rule, we require all pull requests to have at least one approval, but it's a little bit burdensome to grant write permission on a repository for an approval that "counts." A user shouldn't need to be able to write to a repository just to offer an opinion about the quality of a pull request!

There are dozens of people who have write permissions to some of my repositories just because they've approved a pull request at some point. It would be surprising if any of them actually did want to write to the repository.

Suggestions:

• allow repositories to specify what permissions are needed to approve pull requests. Default would be "Write," but it should be possible for anyone to approve a pull request in a public repository.
• an intermediate permission between Read (which is generally everyone for public repositories) and Write (which most pull request approvers don't strictly need).