Fix interactive form in +emacs-lisp/change-working-buffer

[4wardx]

I confirm that...

• I searched the FAQ, issue tracker, discussions board, documentation, and wiki, and found nothing about my issue.

• I read the debugging guide and researched the issue to the best of my ability.

• My issue can be observed on the latest available commit of Doom.

• My issue can be observed on a stable release of Emacs (i.e. doesn't end in .50, .60, or .9*)

Describe your issue

Description
In modules/lang/emacs-lisp/autoload.el, +emacs-lisp/change-working-buffer references all-buffers inside its interactive form before the function arguments are bound.

Invoking the command triggers:

Debugger entered--Lisp error: (void-variable all-buffers)
  (if all-buffers nil
      (let ((buffers (mapcar #'buffer-name (doom-buffer-list))))
        #'(lambda (b)
            (member (or (car-safe b) b) buffers))))

Problematic code

(interactive
 (list (read-buffer
        "Set working buffer to: " (list (current-buffer))
        nil (unless all-buffers
              ...))
       current-prefix-arg))

Fix

- nil (unless all-buffers
+ nil (unless current-prefix-arg

Steps to reproduce

This can be triggered by invoking +emacs-lisp/change-working-buffer, e.g. through:

(map! :localleader
      :map (emacs-lisp-mode-map lisp-interaction-mode-map)
      :desc "Set working buffer" "b" #'+emacs-lisp/change-working-buffer)

System information

N/A

[hlissner]

This has been fixed in doomemacs/core@a543cb7. Thanks for letting me know!

(By the way, these would be better as issues on our issue tracker, since these are certified issues)

[4wardx]

Got it! Thanks for your great work on Doom Emacs!