You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's even slightly worse: the PR to k4RecCalorimeter introduces some small changes on top of the "copy" from MarlinUtil.
Purposes of this discussion
Find a location for this commonly used thing
Figure out where it is actually used and whether it can be replaced
Check whether we still need all the "ILD"-isms that are partially baked in (e.g. the parsing of certain fields from strings / detector names).
Details that can be solved as part of the discussion
The PR in k4RecCalorimeter, introduces an unknown enum state. However, it does so somewhat inconsistently with an already existing unknown state in another enum (see this discussion thread). We need to clarify whether harmonizing these is possible without issues and if so, do so.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
The
CalorimeterHitTypeheader originally from MarlinUtil:has now landed (or is at least on the way of landing) in at least two repositories
It's even slightly worse: the PR to k4RecCalorimeter introduces some small changes on top of the "copy" from MarlinUtil.
Purposes of this discussion
Details that can be solved as part of the discussion
unknownenum state. However, it does so somewhat inconsistently with an already existingunknownstate in another enum (see this discussion thread). We need to clarify whether harmonizing these is possible without issues and if so, do so.All reactions