DISCUSSIONS - RUN button does not execute all statements - only the last or what's selected

[nktnet1]

Description

The run button does not execute all statements. Only the last statement is executed

However, if we've highlighted (selected) any text, the RUN button only executes what's selected - but at the same time, there's a RUN SEL button that appears when we highlight parts of the query. This can be confusing.

Steps to Reproduce

1. Use this query:

   CREATE SCHEMA IF NOT EXISTS sample;
   
   CREATE TABLE IF NOT EXISTS sample.demo (
       id INT PRIMARY KEY,
       name TEXT
   );
   
   INSERT INTO sample.demo VALUES
       (1, 'Test');
   
   SELECT *
   FROM sample.demo;

2. Don't select anything and click RUN.

3. Observe the Query Error:

   schema "sample" does not exist

4. Highlight the whole query with CTRL+A

5. Observe that a RUN SEL button appears

6. Click RUN - now it behaves identical to RUN SEL

Expected Behavior

Clicking RUN should just execute all queries, potentially in a transaction.

Actual Behavior

Only the last statement is executed, or the highlighted (selected) statements if any.

Screenshots

Environment

• LibreDB Studio Version: 0.15.0

Possible Solution

Have RUN execute all statements.

Perhaps introduce a confirmation dialog if there are more than one.

Also consider wrapping in a transaction.

[cevheri]

Yes, this is one of the most discussed topics.

For now, the safest way to run all statements is to select everything in the editor (Ctrl+A) and run it.

The safest default is still to explicitly select the part you want to execute, but I agree that this can be confusing for some users.

Thank you for bringing this up and starting the discussion. I’m converting this issue into a discussion so we can explore the behavior a bit more.

We should aim for an experience that feels familiar to users coming from other database tools.

[nktnet1]

Perhaps just remove the `RUN SEL button?

Since it only ever does the same thing as the RUN button. Perhaps rename the RUN button to RUN SEL when text is selected.

As for the default behaviour when there are multiple statements in the query - perhaps some visual hints showing which statement is currently executed - it's not very intuitive for just the last statement (as opposed to the first) that runs.

[kaya-abdullah]

Agree the diagnosis is right, but I am not fully sold on the proposed fix. Dynamically renaming or swapping a button based on selection state can get flaky, any edge case or timing gap in that logic could leave "RUN SEL" showing when it should not (or vice versa), which just trades one confusing state for another.

Might be worth looking at how other SQL IDEs handle this before settling on an approach. Does anyone know how DBeaver, DataGrip, TablePlus, etc. solve the "run all vs run current statement" problem? A mode toggle, a separate keybinding, statement highlighting, something else? Some precedent here would help pick the right direction.