Replies: 1 comment 1 reply
|
In regards to within our own tool .kt files, if I've been 'generous' with commenting, you'd prefer most cleared out? I've updated 3 files on my repository but had already submitted a successful build. Should I wait until pending approval has finished, or resubmit the build with the minor clean-up ? Cheers. |
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
We are overwhelmingly happy with how dev is going in this repos.
Deeply appreciate the respect, care, and patience shown, and the code submitted has been excellent.
Two little things that have come up a few times, both mentioned in the contribution guidelines:
Please don't open PRs until one of us has indicated on your issue that we'd accept one. I know it's a little annoying since you probably wrote some-if-not-all of the code in order to submit the best issue report possible (y'all have been soooo good about issue reports, thank you). We've just had a few cases where a proposed solution to an issue clashed with some internal work or was overly specific to a tool being built by the submitter. We're such a small team at the moment, it feels easier for us to leave a small directional comment on an Issue before approving than it does to review a whole PR and potentially have to ask for a rewrite. I'm hoping to ease this restriction in the future, given our team can grow a little, we can open up our roadmap a bit, and we're not regularly hurling up giant features.
Comments. If you're using an LLM, please ask it to only leave comments when absolutely necessary, and to keep them as brief as possible. They tend to be superfluous at best, and at worst they can be specific to your particular dev session.
Thanks everyone!
All reactions