[rust-sdk] Could RefreshToken and Token implement Clone?

[rynoV]

Curious if there is a reason for the missing Clone impls for these types while AccessToken does implement clone

https://docs.rs/surrealdb/3.1.5/src/surrealdb/opt/auth.rs.html#315

Also, PartialEq?

[cookesan]

From the current source, this looks mechanically possible, but it is not implemented for those two types today.

AccessToken derives Clone, and the internal SecureToken wrapper also derives Clone. RefreshToken wraps the same SecureToken type, but its derive list omits Clone. Token is:

pub struct Token {
    pub access: AccessToken,
    pub refresh: Option<RefreshToken>,
}

and its derive list also omits Clone.

So the immediate reason is just the derives as written: AccessToken has Clone; RefreshToken and Token do not. I do not see a source comment explaining that the asymmetry is intentional. Since the contained types are cloneable once RefreshToken is, adding Clone to RefreshToken and then to Token seems like the narrow implementation.

The only caveat is API/security intent. These token types deliberately redact debug output and require explicit calls like as_insecure_token() / into_insecure_token() to expose the string. A maintainer may still prefer not to make refresh tokens easier to duplicate, but that would be a policy/API decision rather than a type-system blocker visible in the current source.