chore(build): switch build structure to working on base modules, simplify imports#41
Merged
orhun merged 1 commit intoorhun:mainfrom Mar 14, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
=======================================
Coverage 66.04% 66.04%
=======================================
Files 4 4
Lines 162 162
=======================================
Hits 107 107
Misses 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
orhun
approved these changes
Mar 14, 2025
Owner
orhun
left a comment
There was a problem hiding this comment.
Cool! Should I cut a new release for this or can we wait until a new feature lands / Zig version is updated?
Collaborator
Author
|
No release needed :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zig 0.14 encourages cleaner build script structure by reusing modules: https://ziglang.org/download/0.14.0/release-notes.html#Creating-Artifacts-from-Existing-Modules
This, besides the obvious general improvement, allows us to import all internal modules like
wavvia the local-file@import("wav.zig")mechanism, which makes the whole project more naturally simply include the code it needs, where it needs it.